-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[config reload]Config Reload Enhancement #13969
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failures are due to dependencies on sonic-net/sonic-utilities#2693 sonic-net/sonic-host-services#45 and sonic-net/sonic-mgmt#7558 |
qiluo-msft
reviewed
Feb 27, 2023
qiluo-msft
approved these changes
Mar 18, 2023
Please check conflictions. |
qiluo-msft
approved these changes
Apr 8, 2023
Update sonic-utilities submodule pointer to include the following: * a1057b27 [config reload]Config Reload Enhancement ([sonic-net#2693](sonic-net/sonic-utilities#2693)) * 04d0b34a [voq][chassis][generate_dump] [BCM] Dump only the relevant BCM commands for fabric cards ([sonic-net#2606](sonic-net/sonic-utilities#2606)) Signed-off-by: dgsudharsan <sudharsand@nvidia.com>
b08e940 [config reload] Config Reload Enhancement
qiluo-msft
approved these changes
Apr 12, 2023
dgsudharsan
added a commit
to dgsudharsan/sonic-buildimage
that referenced
this pull request
May 26, 2023
Implementing code changes for sonic-net/SONiC#1203 Removed the timers and delayed target since the delayed services would start based on event driven approach. Cleared port table during config reload and cold reboot scenario. Modified yang model, init_cfg.json to change has_timer to delayed Running regression
10 tasks
dgsudharsan
added a commit
to dgsudharsan/sonic-buildimage
that referenced
this pull request
Jun 10, 2023
Implementing code changes for sonic-net/SONiC#1203 Removed the timers and delayed target since the delayed services would start based on event driven approach. Cleared port table during config reload and cold reboot scenario. Modified yang model, init_cfg.json to change has_timer to delayed Running regression
StormLiangMS
pushed a commit
that referenced
this pull request
Jun 12, 2023
Backporting #13969 Why I did it Implementing code changes for sonic-net/SONiC#1203 Work item tracking Microsoft ADO (number only): How I did it Removed the timers and delayed target since the delayed services would start based on event driven approach. Cleared port table during config reload and cold reboot scenario. Modified yang model, init_cfg.json to change has_timer to delayed How to verify it Added UT to verify
11 tasks
lixiaoyuner
pushed a commit
to lixiaoyuner/sonic-buildimage
that referenced
this pull request
Feb 6, 2024
Fix merge conflict introduced by public PR (sonic-net#13969) Remove gnmi.timer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Implementing code changes for sonic-net/SONiC#1203
How I did it
Removed the timers and delayed target since the delayed services would start based on event driven approach.
Cleared port table during config reload and cold reboot scenario.
Modified yang model, init_cfg.json to change has_timer to delayed
How to verify it
Running regression
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)