Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config reload]Config Reload Enhancement #13969

Merged
merged 12 commits into from
Apr 12, 2023

Conversation

dgsudharsan
Copy link
Collaborator

Why I did it

Implementing code changes for sonic-net/SONiC#1203

How I did it

Removed the timers and delayed target since the delayed services would start based on event driven approach.
Cleared port table during config reload and cold reboot scenario.
Modified yang model, init_cfg.json to change has_timer to delayed

How to verify it

Running regression

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@dgsudharsan
Copy link
Collaborator Author

Failures are due to dependencies on sonic-net/sonic-utilities#2693 sonic-net/sonic-host-services#45 and sonic-net/sonic-mgmt#7558

@dgsudharsan
Copy link
Collaborator Author

@qiluo-msft
Copy link
Collaborator

Please check conflictions.

Update sonic-utilities submodule pointer to include the following:
* a1057b27 [config reload]Config Reload Enhancement ([sonic-net#2693](sonic-net/sonic-utilities#2693))
* 04d0b34a [voq][chassis][generate_dump] [BCM] Dump only the relevant BCM commands for fabric cards ([sonic-net#2606](sonic-net/sonic-utilities#2606))

Signed-off-by: dgsudharsan <sudharsand@nvidia.com>
b08e940 [config reload] Config Reload Enhancement
dgsudharsan and others added 3 commits April 11, 2023 16:20
This reverts commit 88ad212.
Why I did it
Add sonic-dhcpmon as a submodule

How to verify it
Tested dhcpmon on dualtor and single tor
@qiluo-msft qiluo-msft merged commit 2804998 into sonic-net:master Apr 12, 2023
dgsudharsan added a commit to dgsudharsan/sonic-buildimage that referenced this pull request May 26, 2023
Implementing code changes for sonic-net/SONiC#1203

Removed the timers and delayed target since the delayed services would start based on event driven approach.
Cleared port table during config reload and cold reboot scenario.
Modified yang model, init_cfg.json to change has_timer to delayed

Running regression
dgsudharsan added a commit to dgsudharsan/sonic-buildimage that referenced this pull request Jun 10, 2023
Implementing code changes for sonic-net/SONiC#1203

Removed the timers and delayed target since the delayed services would start based on event driven approach.
Cleared port table during config reload and cold reboot scenario.
Modified yang model, init_cfg.json to change has_timer to delayed

Running regression
StormLiangMS pushed a commit that referenced this pull request Jun 12, 2023
Backporting #13969

Why I did it
Implementing code changes for sonic-net/SONiC#1203

Work item tracking
Microsoft ADO (number only):
How I did it
Removed the timers and delayed target since the delayed services would start based on event driven approach.
Cleared port table during config reload and cold reboot scenario.
Modified yang model, init_cfg.json to change has_timer to delayed

How to verify it
Added UT to verify
lixiaoyuner pushed a commit to lixiaoyuner/sonic-buildimage that referenced this pull request Feb 6, 2024
Fix merge conflict introduced by public PR (sonic-net#13969)
Remove gnmi.timer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants