Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TACACS] Stop authorization after user being rejected by server. #14249

Merged
merged 4 commits into from
May 30, 2023
Merged

[TACACS] Stop authorization after user being rejected by server. #14249

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1abcfe3
Stop authorization after user rejected by server.
liuh-80 Mar 15, 2023
e157289
Fix PR comments
liuh-80 May 19, 2023
ed11e64
Fix crlf issue
liuh-80 May 19, 2023
e823635
Fix tab issue
liuh-80 May 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions src/tacacs/nss/patch/0011-Stop-authorization-after-user-rejected-by-serv.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
From f971f48f4e92f0dfbaf02799f0f7515e31a6ec9e Mon Sep 17 00:00:00 2001
From: liuh <liuh@microsoft.com>
Date: Wed, 15 Mar 2023 16:36:52 +0800
Subject: [PATCH] Stop authorization after user rejected by server.

---
nss_tacplus.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/nss_tacplus.c b/nss_tacplus.c
index 048745a..de26306 100644
--- a/nss_tacplus.c
+++ b/nss_tacplus.c
@@ -866,7 +866,12 @@ lookup_tacacs_user(struct pwbuf *pb)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch looks good to me. On the file location, I am thinking modifying 0001-Modify-user-map-profile.patch may be better since you are modifying a function which overlapped there. And it is really diffcult to read a patch on another patch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, I create this draft PR for code review: https://github.com/liuh-80/libnss-tacplus/pull/1/files

" invalid (%d)", nssname,
tac_ntop(tac_srv[srvr].addr->ai_addr), pb->name,
arep.status);
+
+ if (arep.status == TAC_PLUS_AUTHOR_STATUS_FAIL) {
+ done = 1; /* break out of loop after server reject user */
+ }
}
+
if(arep.msg)
free(arep.msg);
if(arep.attr) /* free returned attributes */
--
2.39.0.windows.2