Updated default ECN settings for T2 chassis #14388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmittal-msft
force-pushed
the
vmittal/ecn
branch
from
be8a5e3
to
1f20b31
Compare
neethajohn
reviewed
Mar 23, 2023
device/arista/x86_64-arista_7800r3_48cq2_lc/Arista-7800R3-48CQ2-C48/qos.json.j2
Show resolved
Hide resolved
vmittal-msft
force-pushed
the
vmittal/ecn
branch
2 times, most recently
from
53f164f
to
8961af6
Compare
|
/azp run |
|
Commenter does not have sufficient privileges for PR 14388 in repo sonic-net/sonic-buildimage |
vmittal-msft
added
Chassis for 202205 branch
neethajohn
reviewed
May 2, 2023
neethajohn
approved these changes
May 4, 2023
gechiang
added
the
Included in Chassis for 202205 Branch
vmittal-msft
added
Request for 202205 Branch
and removed
Chassis for 202205 branch
|
@vmittal-msft , is this PR included in 202205? |
gechiang
removed
the
Included in Chassis for 202205 Branch
|
Removed "Included in Chassis for 202205 Branch" as @vmittal-msft wanted this be part of the 202205 branch. |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jun 15, 2023
Why I did it Update ECN settings for T2 chassis How I did it Updated qos config file to load these settings during switch bootup How to verify it Verified on line card on T2 chassis
|
Cherry-pick PR to 202211: #15478 |
|
@vmittal-msft PR conflicts with 202205 branch |
8 tasks
vmittal-msft
added a commit
to vmittal-msft/sonic-buildimage
that referenced
this pull request
Jun 19, 2023
Why I did it Update ECN settings for T2 chassis How I did it Updated qos config file to load these settings during switch bootup How to verify it Verified on line card on T2 chassis
11 tasks
yxieca
pushed a commit
that referenced
this pull request
Jun 22, 2023
* Updated default ECN settings for T2 chassis (#14388) Why I did it Update ECN settings for T2 chassis How I did it Updated qos config file to load these settings during switch bootup How to verify it Verified on line card on T2 chassis * Fix for test failures * Test case failures * test case fix
|
@vmittal-msft cherry pick PR didn't pass PR checker. Please check!!! |
2 similar comments
|
@vmittal-msft cherry pick PR didn't pass PR checker. Please check!!! |
|
@vmittal-msft cherry pick PR didn't pass PR checker. Please check!!! |
|
PR 15478 failed for UT failure. This PR can't be cherry picked to 202211. |
mlok-nokia
pushed a commit
to mlok-nokia/sonic-buildimage
that referenced
this pull request
Jun 5, 2024
Why I did it Update ECN settings for T2 chassis How I did it Updated qos config file to load these settings during switch bootup How to verify it Verified on line card on T2 chassis
mlok-nokia
pushed a commit
to mlok-nokia/sonic-buildimage
that referenced
this pull request
Jun 5, 2024
This reverts commit 56e8cae.
mlok-nokia
pushed a commit
to mlok-nokia/sonic-buildimage
that referenced
this pull request
Jun 5, 2024
Revert "Updated default ECN settings for T2 chassis (sonic-net#14388)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Update ECN settings for T2 chassis
MSFT ADO # 17880888
How I did it
Updated qos config file to load these settings during switch bootup
How to verify it
Verified on line card on T2 chassis
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)