[libnl3] Fix runtime dependencies for libnl-genl-3 and libnl-route-3 #1440

jleveque · 2018-03-01T23:35:15Z

Previously, libnl-genl-3 and libnl-route-3 did not specify libnl-3 as a runtime dependency. However, libnl-nf-3 specified libnl-route-3 as a dependency and libnl-cli-3 specified libnl-genl-3, libnl-nf-3 and libnl-route-3 as dependencies. When passed through the expand function in rules/functions, this would cause libnl-genl-3, libnl-nf-3 and libnl-route-3 to be specified before libnl-3, which would cause libnl-genl-3, libnl-nf-3 and libnl-route-3 packages to fail to install.

Here's the previous (incorrect) output from a Jinja2 template-generated Dockerfile which specified libswsscommon as a dependency. This would present failures:

COPY debs/libnl-route-3-200_3.2.27-1_amd64.deb /debs/
COPY debs/libnl-genl-3-200_3.2.27-1_amd64.deb /debs/
COPY debs/libnl-nf-3-200_3.2.27-1_amd64.deb /debs/
COPY debs/libhiredis0.13_0.13.3-2_amd64.deb /debs/
COPY debs/libnl-3-200_3.2.27-1_amd64.deb /debs/
COPY debs/libnl-cli-3-200_3.2.27-1_amd64.deb /debs/
COPY debs/libswsscommon_1.0.0_amd64.deb /debs/

And here's the output from the same generated Dockerfile after this change is applied. Note the correct ordering of the dependencies:

COPY debs/libnl-3-200_3.2.27-1_amd64.deb /debs/
COPY debs/libnl-route-3-200_3.2.27-1_amd64.deb /debs/
COPY debs/libnl-genl-3-200_3.2.27-1_amd64.deb /debs/
COPY debs/libnl-nf-3-200_3.2.27-1_amd64.deb /debs/
COPY debs/libhiredis0.13_0.13.3-2_amd64.deb /debs/
COPY debs/libnl-cli-3-200_3.2.27-1_amd64.deb /debs/
COPY debs/libswsscommon_1.0.0_amd64.deb /debs/

[swss] [acl] Replace IP_PROTOCOL with NEXT_HEADER for IPv6 ACL tables (#1458) [acl] Refactor port OID retrieval into aclorch (#1462) Fix issue #5157 by identifying the dependency among objects and avoiding releasing an object still being referenced (#1440) [mock tests] Update MockDBConnector to match new swsscommon interface (#1465) [swss-common] netlink: Setting nl_socket buffer size to 3M from 2M (#391) Added support in Swig file to cast Selectable object to Subscriber Table object (#394) [warm reboot] Warm Reboot Support for EVPN VXLAN (#350) Implement DBInterface/SonicV2Connector in C++ (#387) Fix memory leak if a RedisCommand object were to be reused (#392) Signed-off-by: Danny Allen <daall@microsoft.com>

[swss] [acl] Replace IP_PROTOCOL with NEXT_HEADER for IPv6 ACL tables (sonic-net#1458) [acl] Refactor port OID retrieval into aclorch (sonic-net#1462) Fix issue sonic-net#5157 by identifying the dependency among objects and avoiding releasing an object still being referenced (sonic-net#1440) [mock tests] Update MockDBConnector to match new swsscommon interface (sonic-net#1465) [swss-common] netlink: Setting nl_socket buffer size to 3M from 2M (sonic-net#391) Added support in Swig file to cast Selectable object to Subscriber Table object (sonic-net#394) [warm reboot] Warm Reboot Support for EVPN VXLAN (sonic-net#350) Implement DBInterface/SonicV2Connector in C++ (sonic-net#387) Fix memory leak if a RedisCommand object were to be reused (sonic-net#392) Signed-off-by: Danny Allen <daall@microsoft.com>

As per latest update in DPB DOC, fixed this bug previously we had string value in "breakout_modes" key so it was not matching the whole string, But after the update via, now "breakout_modes" contain a dictionary where key is the breakout_mode and value is the alias. So we can easily check whether the key is present or not. Signed-off-by: Sangita Maity <samaity@linkedin.com> Co-authored-by: Guohan Lu <lguohan@gmail.com>

…and avoiding releasing an object still being referenced (sonic-net#1440) * Fix issue sonic-net#5157 by identifying the dependency among objects and avoiding releasing an object still being referenced The issue is caused by the OA receives notification in an different order in which they were sent. OA doesn't have any dependency check try notifying sai-redis to release an object which is still being referenced, which causes sai-redis complain and the object leaks. The idea is to introduce a mechanism to identify the dependency thus preventing a referenced object from being released. 1. Introduce a new type representing the dependency among variant type of objects, including the following fields: - m_objsDependingOnMe, a set representing the objects that references the current object. eg. BUFFER_PROFILE.ingress_lossless_profile references BUFFER_POOL.ingress_lossless_pool - m_objsReferencingByMe, a map from a field of the current object's to the object name it references. 2. When a field of an object A has been updated with referencing another object B, - obj[A.m_objsReferencingByMe[field name]].m_objsDependingOnMe.remove(A) - A.m_objsReferencingByMe[field name] = B 3. When a an object A is about to be removed, - if obj.m_objsDependingOnMe isn't empty set, return task_need_retry else execute the normal remove flow. Signed-off-by: Stephen Sun <stephens@nvidia.com>

…tically (#20540) #### Why I did it src/sonic-sairedis ``` * e394ced7 - (HEAD -> master, origin/master, origin/HEAD) Fix compilation on Buster (#1449) (11 hours ago) [Saikrishna Arcot] * 4d504ff8 - Rename file name to fit case insensitive file system. (#1444) (2 days ago) [Liu Shilong] * fe650bb7 - [syncd] Add workaround for port error status notification (#1430) (6 days ago) [Kamil Cudnik] * cd2773a3 - [syncd] Fix inspect asic command (#1434) (7 days ago) [Kamil Cudnik] * 2d873766 - [syncd] Make sure notification queue release memory when drained (#1427) (8 days ago) [Kamil Cudnik] * b8a8856a - Fix adding flex counter to wrong context (#1421) (8 days ago) [byu343] * 40979e0b - [fastboot] Notify SAI that fastboot is done (#1396) (8 days ago) [Junchao-Mellanox] * 952ee406 - [codeql] Change pull_request_target to pull_request (#1442) (9 days ago) [Kamil Cudnik] * 697d86b5 - [syncd] Create neighbor entries before next hop (#1432) (9 days ago) [Kamil Cudnik] * fa76ca13 - [codeql] Remove git ancestry (#1441) (10 days ago) [Kamil Cudnik] * 3838d7ee - [codeql] Show git ancestry graph (#1440) (10 days ago) [Kamil Cudnik] * 2e7d946b - [codeql] Show gcc version before compile (#1438) (10 days ago) [Kamil Cudnik] * a1e93f58 - [submodule] Update SAI to latest master (#1431) (2 weeks ago) [Kamil Cudnik] ``` #### How I did it #### How to verify it #### Description for the changelog

…tically (sonic-net#20540) #### Why I did it src/sonic-sairedis ``` * e394ced7 - (HEAD -> master, origin/master, origin/HEAD) Fix compilation on Buster (sonic-net#1449) (11 hours ago) [Saikrishna Arcot] * 4d504ff8 - Rename file name to fit case insensitive file system. (sonic-net#1444) (2 days ago) [Liu Shilong] * fe650bb7 - [syncd] Add workaround for port error status notification (sonic-net#1430) (6 days ago) [Kamil Cudnik] * cd2773a3 - [syncd] Fix inspect asic command (sonic-net#1434) (7 days ago) [Kamil Cudnik] * 2d873766 - [syncd] Make sure notification queue release memory when drained (sonic-net#1427) (8 days ago) [Kamil Cudnik] * b8a8856a - Fix adding flex counter to wrong context (sonic-net#1421) (8 days ago) [byu343] * 40979e0b - [fastboot] Notify SAI that fastboot is done (sonic-net#1396) (8 days ago) [Junchao-Mellanox] * 952ee406 - [codeql] Change pull_request_target to pull_request (sonic-net#1442) (9 days ago) [Kamil Cudnik] * 697d86b5 - [syncd] Create neighbor entries before next hop (sonic-net#1432) (9 days ago) [Kamil Cudnik] * fa76ca13 - [codeql] Remove git ancestry (sonic-net#1441) (10 days ago) [Kamil Cudnik] * 3838d7ee - [codeql] Show git ancestry graph (sonic-net#1440) (10 days ago) [Kamil Cudnik] * 2e7d946b - [codeql] Show gcc version before compile (sonic-net#1438) (10 days ago) [Kamil Cudnik] * a1e93f58 - [submodule] Update SAI to latest master (sonic-net#1431) (2 weeks ago) [Kamil Cudnik] ``` #### How I did it #### How to verify it #### Description for the changelog

[libnl3] Fix runtime dependencies for libnl-genl-3 and libnl-route-3

8c45539

jleveque added the Bug 🐛 label Mar 1, 2018

jleveque self-assigned this Mar 1, 2018

jleveque requested review from lguohan and marian-pritsak March 1, 2018 23:35

lguohan approved these changes Mar 2, 2018

View reviewed changes

jleveque merged commit eaea792 into sonic-net:master Mar 2, 2018

jleveque deleted the fix_libnl_rdepends branch March 2, 2018 19:05

daall mentioned this pull request Oct 14, 2020

[swss] Update swss and swss-common submodule pointers #5630

Merged

jleveque mentioned this pull request Feb 24, 2021

[sonic-utilities] Update submodule #6874

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[libnl3] Fix runtime dependencies for libnl-genl-3 and libnl-route-3 #1440

[libnl3] Fix runtime dependencies for libnl-genl-3 and libnl-route-3 #1440

jleveque commented Mar 1, 2018 •

edited

Loading

[libnl3] Fix runtime dependencies for libnl-genl-3 and libnl-route-3 #1440

[libnl3] Fix runtime dependencies for libnl-genl-3 and libnl-route-3 #1440

Conversation

jleveque commented Mar 1, 2018 • edited Loading

jleveque commented Mar 1, 2018 •

edited

Loading