Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install ptf afpacket module required by ptf_nn_agent. #14503

Merged
merged 1 commit into from
May 17, 2023

Conversation

ysmanman
Copy link
Contributor

@ysmanman ysmanman commented Apr 3, 2023

Why I did it

ptf_nn_agent failed to start in dnx rpc syncd because module afpacket was not installed.
Please see issue sonic-net/sonic-mgmt#7822

How I did it

Add downloading ptf afpacket module in docker file.

How to verify it

Verified that ptf_nn_agent was started successfully in dnx rpc syncd with the change.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • [ x] 202205
  • 202211

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Sorry, something went wrong.

@ysmanman ysmanman requested a review from lguohan as a code owner April 3, 2023 17:03
@ysmanman
Copy link
Contributor Author

ysmanman commented Apr 3, 2023

Add @abdosi and @arlakshm for visibility.

@arlakshm
Copy link
Contributor

I am curious why this change is not required on other platforms. @abdosi @bingwang-ms can you look at this change

@arlakshm arlakshm added Request for 202111 Branch For PRs being requested for 202111 branch Request for 202205 Branch labels Apr 10, 2023
@ysmanman
Copy link
Contributor Author

I am curious why this change is not required on other platforms. @abdosi @bingwang-ms can you look at this change

copp test does not use swap_syncd by default https://github.com/sonic-net/sonic-mgmt/blob/708ffc3ac7dd6fd08beacd5dac71e287eec6856f/tests/copp/conftest.py#L14. This is probably why the change is not required by other platforms.

@rlhui rlhui requested a review from mlok-nokia May 3, 2023 17:28
@kenneth-arista
Copy link
Contributor

To add more context. This fix is needed for multi-ASIC copp tests.

@kenneth-arista
Copy link
Contributor

Gentle bump. Can we merge this PR?

@rlhui
Copy link
Contributor

rlhui commented May 17, 2023

@yxieca please help merge? thanks

@yxieca yxieca merged commit 21bcaab into sonic-net:master May 17, 2023
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request May 17, 2023
Why I did it
ptf_nn_agent failed to start in dnx rpc syncd because module afpacket was not installed.
Please see issue sonic-net/sonic-mgmt#7822

How I did it
Add downloading ptf afpacket module in docker file.

How to verify it
Verified that ptf_nn_agent was started successfully in dnx rpc syncd with the change.
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202211: #15119

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request May 17, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Why I did it
ptf_nn_agent failed to start in dnx rpc syncd because module afpacket was not installed.
Please see issue sonic-net/sonic-mgmt#7822

How I did it
Add downloading ptf afpacket module in docker file.

How to verify it
Verified that ptf_nn_agent was started successfully in dnx rpc syncd with the change.
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202205: #15120

mssonicbld pushed a commit that referenced this pull request May 17, 2023
Why I did it
ptf_nn_agent failed to start in dnx rpc syncd because module afpacket was not installed.
Please see issue sonic-net/sonic-mgmt#7822

How I did it
Add downloading ptf afpacket module in docker file.

How to verify it
Verified that ptf_nn_agent was started successfully in dnx rpc syncd with the change.
mssonicbld pushed a commit that referenced this pull request May 17, 2023
Why I did it
ptf_nn_agent failed to start in dnx rpc syncd because module afpacket was not installed.
Please see issue sonic-net/sonic-mgmt#7822

How I did it
Add downloading ptf afpacket module in docker file.

How to verify it
Verified that ptf_nn_agent was started successfully in dnx rpc syncd with the change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants