Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify yang model to handle subport in PORT table #14519

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

mihirpat1
Copy link
Contributor

@mihirpat1 mihirpat1 commented Apr 4, 2023

Why I did it

Based on the port breakout HLD, we are now using subport instead of channel in the CONFIG_DB PORT table to handle port breakout. The yang schema needs to be modified accordingly to handle the corresponding change.
The corresponding code changes have been merged through sonic-net/sonic-platform-daemons/pull/342 merged

How I did it

Replaced channel with subport in the Yang model handling PORT table

How to verify it

The corresponding unit-tests passed for this change.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Mihir Patel <patelmi@microsoft.com>
@mihirpat1 mihirpat1 requested a review from prgeor April 4, 2023 22:48
@mihirpat1 mihirpat1 marked this pull request as ready for review April 4, 2023 22:51
@mihirpat1 mihirpat1 requested a review from qiluo-msft as a code owner April 4, 2023 22:51
@mihirpat1 mihirpat1 added the YANG YANG model related changes label Apr 4, 2023
@mihirpat1
Copy link
Contributor Author

@shyam77git - Can you please help in reviewing this

@mihirpat1
Copy link
Contributor Author

@ganglyu - Can you please help in reviewing this?

@prgeor
Copy link
Contributor

prgeor commented Apr 5, 2023

@lguohan could you help merge

@lguohan lguohan merged commit 63cee3f into sonic-net:master Apr 6, 2023
@mihirpat1
Copy link
Contributor Author

mihirpat1 commented Apr 7, 2023

@yxieca - Can you please help with cherry-pick to 202205
@StormLiangMS - Can you please help with cherry-pick to 202211

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Apr 19, 2023
…14519)

Based on the port breakout HLD, we are now using subport instead of channel in the CONFIG_DB PORT table to handle port breakout. The yang schema needs to be modified accordingly to handle the corresponding change.
The corresponding code changes have been merged through sonic-net/sonic-platform-daemons/pull/342 merged

Signed-off-by: Mihir Patel <patelmi@microsoft.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202205: #14727

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Apr 20, 2023
…14519)

Based on the port breakout HLD, we are now using subport instead of channel in the CONFIG_DB PORT table to handle port breakout. The yang schema needs to be modified accordingly to handle the corresponding change.
The corresponding code changes have been merged through sonic-net/sonic-platform-daemons/pull/342 merged

Signed-off-by: Mihir Patel <patelmi@microsoft.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202211: #14772

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants