Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] [202211] Remove iproute2 SDK patches from SONiC tree and consume them from SDK github #15061

Merged

Conversation

liorghub
Copy link
Contributor

Why I did it

SDK patches for iproute2 were added to SONiC tree as a temporary solution.
Now that SDK with the patches is available, I have removed the patches from SONiC tree and we consume them from SDK github during compilation.

How I did it

During build we download SDK iproute2 patches from SDK github (or from the URL provided by user if compiling SDK from sources) and apply them before compilation.

How to verify it

Compile and load on switch, verify interfaces network devices created successfully.
Verify LLDP shows connections to neighbors.
Verify ping between 2 hosts over 2 router ports is successful.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@liorghub liorghub requested a review from lguohan as a code owner May 14, 2023 12:46
@liorghub liorghub marked this pull request as draft May 14, 2023 12:46
@liorghub
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@liorghub
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liorghub liorghub marked this pull request as ready for review May 28, 2023 12:20
@dprital dprital requested a review from liat-grozovik June 13, 2023 07:25
@liat-grozovik liat-grozovik changed the title [Nvidia] [202211] Remove iproute2 SDK patches from SONiC tree and consume them from SDK github [Mellanox] [202211] Remove iproute2 SDK patches from SONiC tree and consume them from SDK github Jun 13, 2023
@liat-grozovik
Copy link
Collaborator

@liorghub can you confirm that the PR on master is not cherry pickable and thus we have dedicated PR? if so, I will be able to merge this one.

@liorghub
Copy link
Contributor Author

@liat-grozovik
I created this PR (for 202211) since cherry pick was not clean at the time (added by us issue with dhcpmon).
However, now cherry pick is clean so we can either merge this PR or close it and cherry pick master PR (#15062).

@liat-grozovik
Copy link
Collaborator

@StormLiangMS please help to merge to 202211.

Copy link
Contributor

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit d268506 into sonic-net:202211 Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants