Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add 127.0.0.1/8 when bringing down the interfaces #15080

Merged
merged 2 commits into from
Jun 14, 2023

Commits on May 15, 2023

  1. Re-add 127.0.0.1/8 when bringing down the interfaces

    With sonic-net#5353, 127.0.0.1/16 was added to the lo interface, and then
    127.0.0.1/8 was removed. However, when bringing down the lo interface,
    like during a config reload, 127.0.0.1/16 gets removed, but 127.0.0.1/8
    isn't added back to the interface. This means that there's a period of
    time where 127.0.0.1 is not available at all, and services that need to
    connect to 127.0.01 (such as for redis DB) will fail.
    
    To fix this, when going down, add 127.0.0.1/8. Add this address before
    the existing configuration gets removed, so that 127.0.0.1 is available
    at all times.
    
    Note that running `ifdown lo` doesn't actually bring down the loopback
    interface; the interface always stays "physically" up.
    
    Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
    saiarcot895 committed May 15, 2023
    Configuration menu
    Copy the full SHA
    5566a58 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. Update test cases

    Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
    saiarcot895 committed May 16, 2023
    Configuration menu
    Copy the full SHA
    d8aede7 View commit details
    Browse the repository at this point in the history