-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the divide by 4 operation to the under the hood SAI #1532
Conversation
This is to avoid the need and thus the confusion for application program to know the mmu internal architecture This change must have support from SAI change to reach the correct config Signed-off-by: Wenda <wenni@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wenda,
You need to change 7260, 7060, and 6100 at the same time. Basically, any TH, TH2 platform with buffer configuration needs to be updated. And you also need to wait until the sai update is in place before merging it.
retest this please |
lossless pool Extend to 7060 and 6100 Signed-off-by: Wenda <wenni@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please let me merge it.
I need to get SAI upgraded first.
Thanks,
Ying
Signed-off-by: Wenda Ni <wenni@microsoft.com>
Signed-off-by: Wenda Ni <wenni@microsoft.com>
Signed-off-by: Wenda Ni <wenni@microsoft.com>
Signed-off-by: Wenda Ni <wenni@microsoft.com>
- Broadcom SAI 3.5 GA release 20190924. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
retest this please |
* Remove the divide by 4 operation to the under the hood SAI This is to avoid the need and thus the confusion for application program to know the mmu internal architecture This change must have support from SAI change to reach the correct config Signed-off-by: Wenda <wenni@microsoft.com> * Relegate the divide by 4 operation to the under the hood SAI for egress lossless pool Extend to 7060 and 6100 Signed-off-by: Wenda <wenni@microsoft.com> * Add more TH/TH2 hwskus Signed-off-by: Wenda Ni <wenni@microsoft.com> * Update config test Signed-off-by: Wenda Ni <wenni@microsoft.com> * Add TH2 ingress lossy profile Signed-off-by: Wenda Ni <wenni@microsoft.com> * Move the divide by 4 operation to SAI internal Signed-off-by: Wenda Ni <wenni@microsoft.com> * [bcm SAI] Upgrade Broadcom SAI to version 3.5.3.1-15 - Broadcom SAI 3.5 GA release 20190924. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Including folowing changes: - [portsorch] adjust port initialized event back to notice (sonic-net#1532) Signed-off-by: Ying Xie <ying.xie@microsoft.com>
- Why I did it Advance swss submodule to pick up latest changes. - How I did it Including folowing changes: [portsorch] adjust port initialized event back to notice (#1532) Signed-off-by: Ying Xie ying.xie@microsoft.com
This is to avoid the need and thus the confusion for application program to know
the mmu internal architecture
This change must have support from SAI change to reach the correct
config
Signed-off-by: Wenda wenni@microsoft.com
- What I did
Delegate the divide-by-4 operation in setting the static threshold of egress queue for lossless traffic to the underneath SAI.
- How I did it
Change the buffers config json.
- How to verify it
Change the config_db.json on a7260 and dump the config after the change for verification.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)