Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the divide by 4 operation to the under the hood SAI #1532

Merged
merged 18 commits into from
Sep 25, 2019

Conversation

wendani
Copy link
Contributor

@wendani wendani commented Mar 26, 2018

This is to avoid the need and thus the confusion for application program to know
the mmu internal architecture

This change must have support from SAI change to reach the correct
config

Signed-off-by: Wenda wenni@microsoft.com

- What I did
Delegate the divide-by-4 operation in setting the static threshold of egress queue for lossless traffic to the underneath SAI.

- How I did it
Change the buffers config json.

grep -rl 3995680 . | xargs sed -i 's/3995680/15982720/g'
grep -rl 10587408 . | xargs sed -i 's/10587408/42349632/g'   
grep -rl 11075584 . | xargs sed -i 's/11075584/44302336/g'

- How to verify it
Change the config_db.json on a7260 and dump the config after the change for verification.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

This is to avoid the need and thus the confusion for application program to know
the mmu internal architecture

This change must have support from SAI change to reach the correct
config

Signed-off-by: Wenda <wenni@microsoft.com>
@wendani wendani requested review from yxieca and lguohan March 26, 2018 19:42
Copy link
Contributor

@yxieca yxieca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wenda,

You need to change 7260, 7060, and 6100 at the same time. Basically, any TH, TH2 platform with buffer configuration needs to be updated. And you also need to wait until the sai update is in place before merging it.

@wendani
Copy link
Contributor Author

wendani commented Mar 28, 2018

retest this please

Copy link
Contributor

@yxieca yxieca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let me merge it.

I need to get SAI upgraded first.

Thanks,
Ying

wendani and others added 4 commits September 11, 2019 21:15
Signed-off-by: Wenda Ni <wenni@microsoft.com>
Signed-off-by: Wenda Ni <wenni@microsoft.com>
- Broadcom SAI 3.5 GA release 20190924.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@yxieca
Copy link
Contributor

yxieca commented Sep 25, 2019

retest this please

@yxieca yxieca merged commit 7b0a5ba into sonic-net:master Sep 25, 2019
yxieca pushed a commit that referenced this pull request Sep 25, 2019
* Remove the divide by 4 operation to the under the hood SAI

This is to avoid the need and thus the confusion for application program to know
the mmu internal architecture

This change must have support from SAI change to reach the correct
config

Signed-off-by: Wenda <wenni@microsoft.com>

* Relegate the divide by 4 operation to the under the hood SAI for egress
lossless pool

Extend to 7060 and 6100

Signed-off-by: Wenda <wenni@microsoft.com>

* Add more TH/TH2 hwskus

Signed-off-by: Wenda Ni <wenni@microsoft.com>

* Update config test

Signed-off-by: Wenda Ni <wenni@microsoft.com>

* Add TH2 ingress lossy profile

Signed-off-by: Wenda Ni <wenni@microsoft.com>

* Move the divide by 4 operation to SAI internal

Signed-off-by: Wenda Ni <wenni@microsoft.com>

* [bcm SAI] Upgrade Broadcom SAI to version 3.5.3.1-15

- Broadcom SAI 3.5 GA release 20190924.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@yxieca yxieca mentioned this pull request Dec 8, 2020
3 tasks
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Dec 8, 2020
Including folowing changes:
- [portsorch] adjust port initialized event back to notice (sonic-net#1532)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
yxieca added a commit that referenced this pull request Dec 10, 2020
- Why I did it
Advance swss submodule to pick up latest changes.

- How I did it
Including folowing changes:

[portsorch] adjust port initialized event back to notice (#1532)
Signed-off-by: Ying Xie ying.xie@microsoft.com
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this pull request Feb 5, 2022
)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants