[yang] Change asn to start from 0 for bgp monitor #15350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganglyu
approved these changes
Jun 8, 2023
ganglyu
approved these changes
Jun 8, 2023
ganglyu
approved these changes
Jun 8, 2023
|
/azp run Azure.sonic-buildimage |
|
Commenter does not have sufficient privileges for PR 15350 in repo sonic-net/sonic-buildimage |
|
/azp run Azure.sonic-buildimage |
|
Commenter does not have sufficient privileges for PR 15350 in repo sonic-net/sonic-buildimage |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jun 15, 2023
#### Why I did it The asn 0 in BGP_MONITOR is invalid by YANG definition. However, the asn 0 in BGP_MONITOR is found in many devices. It was introduced by minigraph where its value is set to 0. To unblock Config Updater test, the short term fix is to accept the asn 0 in BGP_MONITOR. We can revert this after NGS team make all the ASN change in minigraph. ##### Work item tracking - Microsoft ADO **(24186140)**: #### How I did it Change the range #### How to verify it Unit test.
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jun 15, 2023
#### Why I did it The asn 0 in BGP_MONITOR is invalid by YANG definition. However, the asn 0 in BGP_MONITOR is found in many devices. It was introduced by minigraph where its value is set to 0. To unblock Config Updater test, the short term fix is to accept the asn 0 in BGP_MONITOR. We can revert this after NGS team make all the ASN change in minigraph. ##### Work item tracking - Microsoft ADO **(24186140)**: #### How I did it Change the range #### How to verify it Unit test.
|
Cherry-pick PR to 202211: #15483 |
|
Cherry-pick PR to 202205: #15482 |
This was referenced Jun 15, 2023
mssonicbld
added a commit
that referenced
this pull request
Jun 15, 2023
mssonicbld
added
Included in 202211 Branch
and removed
Approved for 202211 Branch
Created PR to 202211 Branch
labels
mssonicbld
added a commit
that referenced
this pull request
Jun 15, 2023
mssonicbld
added
Included in 202205 Branch
and removed
Approved for 202205 Branch
Created PR to 202205 Branch
labels
sonic-otn
pushed a commit
to sonic-otn/sonic-buildimage
that referenced
this pull request
Sep 20, 2023
#### Why I did it The asn 0 in BGP_MONITOR is invalid by YANG definition. However, the asn 0 in BGP_MONITOR is found in many devices. It was introduced by minigraph where its value is set to 0. To unblock Config Updater test, the short term fix is to accept the asn 0 in BGP_MONITOR. We can revert this after NGS team make all the ASN change in minigraph. ##### Work item tracking - Microsoft ADO **(24186140)**: #### How I did it Change the range #### How to verify it Unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
The asn 0 in BGP_MONITOR is invalid by YANG definition. However, the asn 0 in BGP_MONITOR is found in many devices.
It was introduced by minigraph where its value is set to 0.
To unblock Config Updater test, the short term fix is to accept the asn 0 in BGP_MONITOR.
We can revert this after NGS team make all the ASN change in minigraph.
Work item tracking
How I did it
Change the range
How to verify it
Unit test.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)