[action] [PR:15265] Added change to add 'peerType' as element in NEIGH_STATE_TABLE. #15380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c-net#15265) What I did: Added change to add 'peerType' as element in NEIGH_STATE_TABLE. 'peerType' can be i-BGP vs e-BGP determined based on local and remote AS number. Why I did: This is useful to filter neighbors in SONiC as internal vs external in chassis use-case (example: telemetry) Verification: Manual Verification 127.0.0.1:6379[6]> hgetall "NEIGH_STATE_TABLE|10.0.0.5" 1) "state" 2) "Established" 3) "peerType" 4) "e-BGP" 127.0.0.1:6379[6]> hgetall "NEIGH_STATE_TABLE|2603:10e2:400::4" 1) "state" 2) "Established" 3) "peerType" 4) "i-BGP" Also sonic-mgmt test case test_bgp_fact.py is enhanced: Enhanced bgp_fact to validate NEIGH_STATE_TABLE element 'peerType' sonic-mgmt#8462
|
Original PR: #15265 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:
Added change to add 'peerType' as element in NEIGH_STATE_TABLE.
'peerType' can be i-BGP vs e-BGP determined based on local and remote AS number.
Why I did:
This is useful to filter neighbors in SONiC as internal vs external in chassis use-case (example: telemetry)
Microsoft ADO: https://msazure.visualstudio.com/One/_workitems/edit/24166635
Verification:
test_bgp_fact.pyis enhanced: Enhanced bgp_fact to validate NEIGH_STATE_TABLE element 'peerType' sonic-mgmt#8462