Revert "Fix for fast/cold-boot: call db_migrator only after old config is loaded" #15464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g is loaded (sonic-net#14933)" This reverts commit 02b1783.
vaibhavhd
added
Request for 202012 Branch
Request for 202111 Branch
yxieca
approved these changes
Jun 16, 2023
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jun 16, 2023
…g is loaded (sonic-net#14933)" (sonic-net#15464) This reverts commit 02b1783. Reverts sonic-net#14933 The earlier commit caused a race condition that particularly broke cross branch warm upgrade. Issue happens when db_migrator is still migrating the DB and finalizer is checking DB for list of components to reconcile. If migration is not complete, finalizer get an empty list to wait for. Due to this, finalizer concludes warmboot (deletes system wide warmboot flag) and cause all the services to do cold restart. ADO: 24274591
|
Cherry-pick PR to 202211: #15516 |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jun 16, 2023
…g is loaded (sonic-net#14933)" (sonic-net#15464) This reverts commit 02b1783. Reverts sonic-net#14933 The earlier commit caused a race condition that particularly broke cross branch warm upgrade. Issue happens when db_migrator is still migrating the DB and finalizer is checking DB for list of components to reconcile. If migration is not complete, finalizer get an empty list to wait for. Due to this, finalizer concludes warmboot (deletes system wide warmboot flag) and cause all the services to do cold restart. ADO: 24274591
|
Cherry-pick PR to 202205: #15517 |
mssonicbld
added
Included in 202205 Branch
and removed
Approved for 202205 Branch
Created PR to 202205 Branch
labels
mssonicbld
pushed a commit
that referenced
this pull request
Jun 17, 2023
…g is loaded (#14933)" (#15464) This reverts commit 02b1783. Reverts #14933 The earlier commit caused a race condition that particularly broke cross branch warm upgrade. Issue happens when db_migrator is still migrating the DB and finalizer is checking DB for list of components to reconcile. If migration is not complete, finalizer get an empty list to wait for. Due to this, finalizer concludes warmboot (deletes system wide warmboot flag) and cause all the services to do cold restart. ADO: 24274591
mssonicbld
added
Included in 202211 Branch
and removed
Approved for 202211 Branch
Created PR to 202211 Branch
labels
|
Cherry-pick PR to 202305: #15618 |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jun 24, 2023
…g is loaded (sonic-net#14933)" (sonic-net#15464) This reverts commit 02b1783. Reverts sonic-net#14933 The earlier commit caused a race condition that particularly broke cross branch warm upgrade. Issue happens when db_migrator is still migrating the DB and finalizer is checking DB for list of components to reconcile. If migration is not complete, finalizer get an empty list to wait for. Due to this, finalizer concludes warmboot (deletes system wide warmboot flag) and cause all the services to do cold restart. ADO: 24274591
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jun 29, 2023
…g is loaded (sonic-net#14933)" (sonic-net#15464) This reverts commit 02b1783. Reverts sonic-net#14933 The earlier commit caused a race condition that particularly broke cross branch warm upgrade. Issue happens when db_migrator is still migrating the DB and finalizer is checking DB for list of components to reconcile. If migration is not complete, finalizer get an empty list to wait for. Due to this, finalizer concludes warmboot (deletes system wide warmboot flag) and cause all the services to do cold restart. ADO: 24274591
|
Cherry-pick PR to 202012: #15653 |
mssonicbld
pushed a commit
that referenced
this pull request
Jun 29, 2023
…g is loaded (#14933)" (#15464) This reverts commit 02b1783. Reverts #14933 The earlier commit caused a race condition that particularly broke cross branch warm upgrade. Issue happens when db_migrator is still migrating the DB and finalizer is checking DB for list of components to reconcile. If migration is not complete, finalizer get an empty list to wait for. Due to this, finalizer concludes warmboot (deletes system wide warmboot flag) and cause all the services to do cold restart. ADO: 24274591
mssonicbld
added
Included in 202012 Branch
and removed
Approved for 202012 Branch
Created PR to 202012 Branch
labels
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
vaibhavhd
added a commit
to vaibhavhd/sonic-buildimage
that referenced
this pull request
Jun 30, 2023
…ld config is loaded (sonic-net#14933)" (sonic-net#15464)" This reverts commit 9649a44.
Merged
10 tasks
yxieca
pushed a commit
that referenced
this pull request
Jul 7, 2023
10 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jul 7, 2023
…ld config is loaded (sonic-net#14933)" (sonic-net#15464)" (sonic-net#15684) This reverts commit 9649a44.
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jul 7, 2023
…ld config is loaded (sonic-net#14933)" (sonic-net#15464)" (sonic-net#15684) This reverts commit 9649a44.
10 tasks
mssonicbld
added a commit
that referenced
this pull request
Jul 7, 2023
mssonicbld
added a commit
that referenced
this pull request
Jul 7, 2023
10 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Aug 14, 2023
…ld config is loaded (sonic-net#14933)" (sonic-net#15464)" (sonic-net#15684) This reverts commit 9649a44.
mssonicbld
pushed a commit
that referenced
this pull request
Aug 14, 2023
10 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Aug 21, 2023
…ld config is loaded (sonic-net#14933)" (sonic-net#15464)" (sonic-net#15684) This reverts commit 9649a44.
mssonicbld
added a commit
that referenced
this pull request
Aug 21, 2023
sonic-otn
pushed a commit
to sonic-otn/sonic-buildimage
that referenced
this pull request
Sep 20, 2023
…g is loaded (sonic-net#14933)" (sonic-net#15464) This reverts commit 02b1783. Reverts sonic-net#14933 The earlier commit caused a race condition that particularly broke cross branch warm upgrade. Issue happens when db_migrator is still migrating the DB and finalizer is checking DB for list of components to reconcile. If migration is not complete, finalizer get an empty list to wait for. Due to this, finalizer concludes warmboot (deletes system wide warmboot flag) and cause all the services to do cold restart. ADO: 24274591
sonic-otn
pushed a commit
to sonic-otn/sonic-buildimage
that referenced
this pull request
Sep 20, 2023
…ld config is loaded (sonic-net#14933)" (sonic-net#15464)" (sonic-net#15684) This reverts commit 9649a44.
lixiaoyuner
pushed a commit
to lixiaoyuner/sonic-buildimage
that referenced
this pull request
Feb 6, 2024
Related work items: sonic-net#94, sonic-net#13789, sonic-net#14149, sonic-net#14515, sonic-net#14788, sonic-net#14922, sonic-net#14933, sonic-net#15284, sonic-net#15383, sonic-net#15464, sonic-net#15519, sonic-net#15521, sonic-net#15575, sonic-net#15636, sonic-net#15652, sonic-net#15684, sonic-net#15708, sonic-net#15725, sonic-net#15739, sonic-net#15755, sonic-net#15756, sonic-net#15757
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #14933
The earlier commit caused a race condition that particularly broke cross branch warm upgrade.
Issue happens when db_migrator is still migrating the DB and finalizer is checking DB for list of components to reconcile.
If migration is not complete, finalizer get an empty list to wait for. Due to this, finalizer concludes warmboot (deletes system wide warmboot flag) and cause all the services to do cold restart.
ADO: 24274591