Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate flush_unused_database from py-redis to sonic-swss-common #15511

Merged
merged 3 commits into from
Jun 29, 2023

Conversation

liuh-80
Copy link
Contributor

@liuh-80 liuh-80 commented Jun 16, 2023

Migrate flush_unused_database from py-redis to sonic-swss-common

Why I did it

flush_unused_database using py-redis, but sonic-swss-common already support flushdb, so we need migrate to sonic-swss-common

Work item tracking
  • Microsoft ADO (number only): 24292565

How I did it

Migrate flush_unused_database from py-redis to sonic-swss-common

How to verify it

Pass all UT and E2E test

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Tested branch (Please provide the tested image version)

Description for the changelog

Migrate flush_unused_database from py-redis to sonic-swss-common

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@liuh-80 liuh-80 changed the title [WIP] Migrate flush_unused_database from py-redis to sonic-swss-common Migrate flush_unused_database from py-redis to sonic-swss-common Jun 19, 2023
@liuh-80 liuh-80 marked this pull request as ready for review June 19, 2023 02:04
@liuh-80 liuh-80 requested a review from lguohan as a code owner June 19, 2023 02:04
@liuh-80 liuh-80 requested a review from qiluo-msft June 19, 2023 02:04
# https://github.com/redis/redis-py/blob/d95d8a24ed2af3eae80b7b0f14cbccc9dbe86e96/redis/client.py#L1006
if instsocket is not None:
# connect with Unix socket
connector = swsscommon.DBConnector(dbid, instsocket, 0)
Copy link
Collaborator

@qiluo-msft qiluo-msft Jun 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor format issue: use only 1 blank after =. #Closed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@qiluo-msft qiluo-msft merged commit c91707f into sonic-net:master Jun 29, 2023
sonic-otn pushed a commit to sonic-otn/sonic-buildimage that referenced this pull request Sep 20, 2023
…ic-net#15511)

Migrate flush_unused_database from py-redis to sonic-swss-common

#### Why I did it
flush_unused_database using py-redis, but sonic-swss-common already support flushdb, so we need migrate to sonic-swss-common

##### Work item tracking
- Microsoft ADO **(number only)**: 24292565

#### How I did it
Migrate flush_unused_database from py-redis to sonic-swss-common

#### How to verify it
Pass all UT and E2E test

#### Description for the changelog
Migrate flush_unused_database from py-redis to sonic-swss-common
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants