Don't build libhiredis anymore #15633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're not adding any patch on top of hiredis, and there's no apparent reason to build this. Remove the build step here, and just install the package from the Debian repos. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
qiluo-msft
reviewed
Jul 26, 2023
| @@ -406,6 +406,8 @@ RUN apt-get update && apt-get install -y \ | |||
| libgirepository1.0-dev \ | |||
| libsystemd-dev \ | |||
| pkg-config \ | |||
| # For sonic-swss-common build | |||
| libhiredis-dev \ | |||
This might not be needed, but adding it, just in case. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
qiluo-msft
approved these changes
Jul 26, 2023
|
/azp run Azure.sonic-buildimage |
|
Commenter does not have sufficient privileges for PR 15633 in repo sonic-net/sonic-buildimage |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
No commit pushedDate could be found for PR 15633 in repo sonic-net/sonic-buildimage |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
saiarcot895
added a commit
to saiarcot895/sonic-host-services
that referenced
this pull request
Sep 8, 2023
libhiredis is now used as-is from the slave container, since we're not making any changes to this package. See also sonic-net/sonic-buildimage#15633. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
saiarcot895
added a commit
to saiarcot895/sonic-utilities
that referenced
this pull request
Sep 13, 2023
libhiredis is now used as-is from the slave container, since we're not making any changes to this package. See also sonic-net/sonic-buildimage#15633. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
saiarcot895
added a commit
to saiarcot895/sonic-platform-common
that referenced
this pull request
Sep 13, 2023
libhiredis is now used as-is from the slave container, since we're not making any changes to this package. See also sonic-net/sonic-buildimage#15633. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
saiarcot895
added a commit
to saiarcot895/sonic-platform-daemons
that referenced
this pull request
Sep 13, 2023
libhiredis is now used as-is from the slave container, since we're not making any changes to this package. See also sonic-net/sonic-buildimage#15633. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
saiarcot895
added a commit
to saiarcot895/sonic-platform-daemons
that referenced
this pull request
Sep 13, 2023
libhiredis is now used as-is from the slave container, since we're not making any changes to this package. See also sonic-net/sonic-buildimage#15633. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
saiarcot895
added a commit
to saiarcot895/sonic-gnmi
that referenced
this pull request
Sep 13, 2023
libhiredis is now used as-is from the slave container, since we're not making any changes to this package. See also sonic-net/sonic-buildimage#15633. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
6 tasks
saiarcot895
added a commit
to saiarcot895/sonic-dbsyncd
that referenced
this pull request
Sep 13, 2023
libhiredis is now used as-is from the slave container, since we're not making any changes to this package. See also sonic-net/sonic-buildimage#15633. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
prgeor
pushed a commit
to sonic-net/sonic-platform-common
that referenced
this pull request
Sep 13, 2023
libhiredis is now used as-is from the slave container, since we're not making any changes to this package. See also sonic-net/sonic-buildimage#15633. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
saiarcot895
added a commit
to saiarcot895/sonic-restapi
that referenced
this pull request
Sep 13, 2023
libhiredis is now used as-is from the slave container, since we're not making any changes to this package. See also sonic-net/sonic-buildimage#15633. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
abdosi
pushed a commit
to sonic-net/sonic-host-services
that referenced
this pull request
Sep 13, 2023
libhiredis is now used as-is from the slave container, since we're not making any changes to this package. See also sonic-net/sonic-buildimage#15633.
prgeor
pushed a commit
to sonic-net/sonic-platform-daemons
that referenced
this pull request
Sep 13, 2023
libhiredis is now used as-is from the slave container, since we're not making any changes to this package. See also sonic-net/sonic-buildimage#15633. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
saiarcot895
added a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Sep 13, 2023
libhiredis is now used as-is from the slave container, since we're not making any changes to this package. See also sonic-net/sonic-buildimage#15633. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
SviatoslavBoichuk
pushed a commit
to SviatoslavBoichuk/sonic-host-services
that referenced
this pull request
Sep 14, 2023
libhiredis is now used as-is from the slave container, since we're not making any changes to this package. See also sonic-net/sonic-buildimage#15633.
This was referenced Sep 15, 2023
qiluo-msft
pushed a commit
to sonic-net/sonic-snmpagent
that referenced
this pull request
Sep 16, 2023
…mage artifect. (#293) Fix pipeline build break caused by libhredis remove from sonic-buildimage artifect. Pipeline build break because sonic-buildimage repo not build libhredis by this PR: sonic-net/sonic-buildimage#15633 **- What I did** Fix pipeline build break caused by libhredis remove from sonic-buildimage artifect. **- How I did it** Install libhiredis0.14 from debian apt source. **- How to verify it** Pass all UT **- Description for the changelog** Fix pipeline build break caused by libhredis remove from sonic-buildimage artifect.
sonic-otn
pushed a commit
to sonic-otn/sonic-buildimage
that referenced
this pull request
Sep 20, 2023
### Why I did it We're not adding any patch on top of hiredis, and there's no apparent reason to build this. Remove the build step here, and just install the package from the Debian repos. ##### Work item tracking - Microsoft ADO **(number only)**: 24381590 #### How to verify it Build the SONiC image, and load it. Verify that services come up.
qiluo-msft
pushed a commit
to sonic-net/sonic-gnmi
that referenced
this pull request
Sep 27, 2023
### Why I did it libhiredis is now used as-is from the slave container, since we're not making any changes to this package. See also sonic-net/sonic-buildimage#15633.
JunhongMao
pushed a commit
to JunhongMao/sonic-utilities
that referenced
this pull request
Oct 4, 2023
libhiredis is now used as-is from the slave container, since we're not making any changes to this package. See also sonic-net/sonic-buildimage#15633. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
prsunny
pushed a commit
to sonic-net/sonic-restapi
that referenced
this pull request
Oct 12, 2023
* Remove command to install libhiredis deb file libhiredis is now used as-is from the slave container, since we're not making any changes to this package. See also sonic-net/sonic-buildimage#15633.
StormLiangMS
pushed a commit
to sonic-net/sonic-gnmi
that referenced
this pull request
Oct 17, 2023
### Why I did it libhiredis is now used as-is from the slave container, since we're not making any changes to this package. See also sonic-net/sonic-buildimage#15633.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
We're not adding any patch on top of hiredis, and there's no apparent reason to build this. Remove the build step here, and just install the package from the Debian repos.
Work item tracking
How I did it
How to verify it
Build the SONiC image, and load it. Verify that services come up.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)