Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue: set has_timer attribute to true for platform monitor service #15711

Closed

Conversation

Junchao-Mellanox
Copy link
Collaborator

Why I did it

There is a redundant line in init_cfg.json.j2. It would cause pmon service always has "has_timer=False". However, we know that PMON has a timer now. So, I try to fix it here.

Work item tracking
  • Microsoft ADO (number only):

How I did it

Remove the redundant line

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@prgeor
Copy link
Contributor

prgeor commented Jul 11, 2023

@Junchao-Mellanox can you elaborate why this change is needed? why PMON need to start late?

@@ -0,0 +1,12 @@
[Unit]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Junchao-Mellanox This will affect the fast-reboot time for link bring up on platform where Xcvrd is responsible for link bring up.

Comment on lines +905 to +906
sudo cp $BUILD_TEMPLATES/pmon.timer $FILESYSTEM_ROOT_USR_LIB_SYSTEMD_SYSTEM
echo "pmon.timer" | sudo tee -a $GENERATED_SERVICE_FILE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Junchao-Mellanox wont this delay the PMON launch for platforms that depend upon Xcvrd to initialize optics during cold reboot and there by affect link bring up time?

@arfeigin
Copy link
Contributor

@Junchao-Mellanox can you elaborate why this change is needed? why PMON need to start late?

Hi, this change was already merged in the past: #10567
As mentioned the motivation was that profiling the system state on init after fast-reboot during create_switch function execution, it is possible to see few python scripts running at the same time.
This parallel execution consume CPU time and the duration of create_switch is longer than it should be.

Bootchart is attached in the mentioned PR.

@Junchao-Mellanox
Copy link
Collaborator Author

i will close this PR since there is another PR #15334. In that PR, it makes pmon delay based on fast reboot status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants