-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue: set has_timer attribute to true for platform monitor service #15711
Conversation
@Junchao-Mellanox can you elaborate why this change is needed? why PMON need to start late? |
@@ -0,0 +1,12 @@ | |||
[Unit] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Junchao-Mellanox This will affect the fast-reboot time for link bring up on platform where Xcvrd is responsible for link bring up.
sudo cp $BUILD_TEMPLATES/pmon.timer $FILESYSTEM_ROOT_USR_LIB_SYSTEMD_SYSTEM | ||
echo "pmon.timer" | sudo tee -a $GENERATED_SERVICE_FILE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Junchao-Mellanox wont this delay the PMON launch for platforms that depend upon Xcvrd to initialize optics during cold reboot and there by affect link bring up time?
Hi, this change was already merged in the past: #10567 Bootchart is attached in the mentioned PR. |
i will close this PR since there is another PR #15334. In that PR, it makes pmon delay based on fast reboot status. |
Why I did it
There is a redundant line in init_cfg.json.j2. It would cause pmon service always has "has_timer=False". However, we know that PMON has a timer now. So, I try to fix it here.
Work item tracking
How I did it
Remove the redundant line
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)