Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[syslog] Add remote syslog configuration (cherry-pick to 202305) #15897

Merged
merged 6 commits into from
Aug 14, 2023

Conversation

fastiuk
Copy link
Contributor

@fastiuk fastiuk commented Jul 18, 2023

cherry-pick: #14513
depends: sonic-net/sonic-utilities#2939

  • Add an ability to configure remote syslog servers
  • Add an initial configuration for remote syslog
  • Extend YANG module and add unit tests

Why I did it

Adding the following functionality to rsyslog feature:

  • Configure remote syslog servers: protocol, filter, severity level
  • Update global syslog configuration: severity level, message format

How I did it

added parameters to syslog server and global configuration.

How to verify it

create syslog server using CLI/adding to Redis-DB
verify server is added to file /etc/rsyslog.conf and server is functional.

Description for the changelog

extend rsyslog capabilities, added server and global configuration parameters.

Link to config_db schema for YANG module changes

sonic-syslog.yang

A picture of a cute animal (it is my cat Finn)

PXL_20230413_140941610 PORTRAIT

@fastiuk fastiuk self-assigned this Jul 18, 2023
@jarias-lfx
Copy link

/easycla

* Add an ability to configure remote syslog servers
* Add an initial configuration for remote syslog
* Extend YANG module and add unit tests

Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>
Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>
Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>
Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>
@fastiuk
Copy link
Contributor Author

fastiuk commented Aug 7, 2023

The failure happens because sonic-net/sonic-utilities#2939 must be merged first.
That is why I mentioned it as "depends on" in the description

@qiluo-msft
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@sonic-net sonic-net deleted a comment from azure-pipelines bot Aug 11, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@fastiuk
Copy link
Contributor Author

fastiuk commented Aug 14, 2023

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Pull request contains merge conflicts.

@fastiuk fastiuk closed this Aug 14, 2023
@fastiuk fastiuk reopened this Aug 14, 2023
@fastiuk
Copy link
Contributor Author

fastiuk commented Aug 14, 2023

@qiluo-msft all checks are passed. It can be merged now

@qiluo-msft qiluo-msft merged commit 4602d30 into sonic-net:202305 Aug 14, 2023
16 checks passed
@qiluo-msft
Copy link
Collaborator

@fastiuk This PR is considered as a new feature. Why cherry-pick to 202305? Should we revert?

@StormLiangMS
Copy link
Contributor

@fastiuk this is new feature, not for 202305, I will revert.

@StormLiangMS
Copy link
Contributor

revert PR #16179

@fastiuk
Copy link
Contributor Author

fastiuk commented Aug 17, 2023

@fastiuk This PR is considered as a new feature. Why cherry-pick to 202305? Should we revert?

@qiluo-msft, @StormLiangMS
That feature was planned for the 202305 release, which is why it was picked into that branch. I don't think we need to revert it.

@StormLiangMS
Copy link
Contributor

StormLiangMS commented Aug 18, 2023

@fastiuk Thanks, I do find this feature was marked done for 202305, but the PR merged by 3 days ago, it is poor practice, when branch cut off (by Jun), not merged PR would be considered not done.

StormLiangMS added a commit that referenced this pull request Sep 14, 2023
StormLiangMS added a commit that referenced this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants