Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign the higher metric value for Ipv6 default route learnt via RA message #16367

Merged
merged 7 commits into from
Sep 1, 2023
Merged

Assign the higher metric value for Ipv6 default route learnt via RA message #16367

merged 7 commits into from
Sep 1, 2023

Conversation

abdosi
Copy link
Contributor

@abdosi abdosi commented Aug 31, 2023 •
edited
Loading

What I did:
Assign the metric value for Ipv6 default route learnt via RA message to
higher value so that BGP learnt default route is higher priority.

This change depend on this Kernel Patch: sonic-net/sonic-linux-kernel#326

ADO: 24888962

Why I did:
Fixes : #16209

How I verify:
Manual Verification to make sure after setting metric e-BGP learnt default is always higher priority over RA default route.

str2-xxxxx-acs-03# show ipv6 route ::/0
Routing entry for ::/0
  Known via "kernel", distance 119, metric 1000
  Last update 00:00:33 ago
    fe80::9a49:25ff:fe03:6e52, via eth0

Routing entry for ::/0
  Known via "bgp", distance 20, metric 0, best
  Last update 00:00:59 ago
  * fc00::2, via PortChannel102, weight 1
  * fc00::a, via PortChannel105, weight 1
  * fc00::12, via PortChannel108, weight 1
  * fc00::1a, via PortChannel1011, weight 1
  * fc00::22, via PortChannel1014, weight 1
  * fc00::2a, via PortChannel1017, weight 1
  * fc00::32, via PortChannel1020, weight 1
  * fc00::3a, via PortChannel1023, weight 1

admin@str2-xxxxx-acs-03:~$ sudo ip -6 route show ::/0 table main
default nhid 297 proto bgp src fc00:1::32 metric 20 pref medium
        nexthop via fc00::2 dev PortChannel102 weight 1
        nexthop via fc00::12 dev PortChannel108 weight 1
        nexthop via fc00::1a dev PortChannel1011 weight 1
        nexthop via fc00::22 dev PortChannel1014 weight 1
        nexthop via fc00::2a dev PortChannel1017 weight 1
        nexthop via fc00::32 dev PortChannel1020 weight 1
        nexthop via fc00::3a dev PortChannel1023 weight 1
        nexthop via fc00::a dev PortChannel105 weight 1
default via fe80::2a01:111:e210:3000:3 dev eth0 proto ra metric 1996489704 expires 1797sec hoplimit 64 pref medium
default via fe80::2a01:111:e210:3000:1 dev eth0 proto ra metric 1996489704 expires 1799sec hoplimit 64 pref medium
default via fe80::2a01:111:e210:3000:2 dev eth0 proto ra metric 1996489704 expires 1797sec hoplimit 64 pref medium
default via fe80::9a49:25ff:fe03:6e52 dev eth0 proto ra metric 1996489704 expires 1797sec hoplimit 64 pref medium

@abdosi abdosi requested a review from lguohan as a code owner August 31, 2023 21:00
@abdosi abdosi requested a review from prsunny August 31, 2023 21:01
@abdosi
Copy link
Contributor Author

abdosi commented Aug 31, 2023 •
edited
Loading

@yxieca / @StormLiangMS this PR depends on sonic-net/sonic-linux-kernel#326 to be cherry-picked and submodule update in corresponding release branch.

@abdosi abdosi requested a review from arlakshm August 31, 2023 21:06
@prsunny
Copy link
Contributor

prsunny commented Sep 1, 2023

@dgsudharsan for viz

@prsunny prsunny merged commit 566b5df into sonic-net:master Sep 1, 2023
19 checks passed
@abdosi
Copy link
Contributor Author

abdosi commented Sep 1, 2023

@yxieca / @StormLiangMS this PR depends on sonic-net/sonic-linux-kernel#326 to be cherry-picked and submodule update in corresponding release branch.

@yxieca this can be cherry-picked now. Submodule is updated for 202205

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Sep 3, 2023
@abdosi @mssonicbld
Assign the higher metric value for Ipv6 default route learnt via RA m…
b9cfb3e 
…essage (sonic-net#16367)

* Fix the Loopback0 IPv6 address of LC's in chassis not reachable from peer device's
* Assign the metric vaule for Ipv6 default route learnt via RA message to higher value so that BGP learnt default route is higher priority.

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202305: #16429

@mssonicbld mssonicbld mentioned this pull request Sep 3, 2023
Merged
mssonicbld added a commit that referenced this pull request Sep 3, 2023
@mssonicbld
Assign the higher metric value for Ipv6 default route learnt via RA m…
40a5cea 
…essage (#16367) (#16429)
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Sep 5, 2023
@abdosi @mssonicbld
Assign the higher metric value for Ipv6 default route learnt via RA m…
e4bc2f3 
…essage (sonic-net#16367)

* Fix the Loopback0 IPv6 address of LC's in chassis not reachable from peer device's
* Assign the metric vaule for Ipv6 default route learnt via RA message to higher value so that BGP learnt default route is higher priority.

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202205: #16440

@mssonicbld mssonicbld mentioned this pull request Sep 5, 2023
Merged
yxieca pushed a commit that referenced this pull request Sep 6, 2023
@mssonicbld @abdosi
Assign the higher metric value for Ipv6 default route learnt via RA m…
d5e2c00 
…essage (#16367) (#16440)

* Fix the Loopback0 IPv6 address of LC's in chassis not reachable from peer device's
* Assign the metric vaule for Ipv6 default route learnt via RA message to higher value so that BGP learnt default route is higher priority.

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Co-authored-by: abdosi <58047199+abdosi@users.noreply.github.com>
sonic-otn pushed a commit to sonic-otn/sonic-buildimage that referenced this pull request Sep 20, 2023
@abdosi @sonic-otn
Assign the higher metric value for Ipv6 default route learnt via RA m…
41b8d26 
…essage (sonic-net#16367)

* Fix the Loopback0 IPv6 address of LC's in chassis not reachable from peer device's
* Assign the metric vaule for Ipv6 default route learnt via RA message to higher value so that BGP learnt default route is higher priority.

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arlakshm arlakshm arlakshm approved these changes

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

@prsunny prsunny Awaiting requested review from prsunny

Assignees
No one assigned
Labels
Approved for 202305 Branch Included in 202205 Branch Included in 202305 Branch Request for 202205 Branch Request for 202211 Branch Request for 202305 Branch
Projects
SONiC Chassis
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ipv6 e-BGP default route not getting programmed if ipv6 management config is not done on eth0
6 participants
@abdosi @prsunny @mssonicbld @arlakshm @yxieca @StormLiangMS