Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[image_config]: Update DHCP rate-limit for mgmt TOR devices #17630

Merged
merged 2 commits into from
Jan 3, 2024

Commits on Dec 28, 2023

  1. [image_config]: Update DHCP rate-limit for mgmt TOR devices

        Change DHCP rate limit(queue4,group3) in SONiC copp configuration to 300 PPS
        for mgmt TORs while keeping the rate limit at 100 PPS for other topologies.
    
        Why I did it:
        Some mgmt TORs based on Marvell ASIC do not support 100 PPS CIR, so that led
        to these devices silently dropping DHCP packets.
    
        Microsoft ADO: **25820076**
    
        How to verify it:
        Send DHCP broadcast packets to an M0 DUT and verify that they are trapped to
        CPU at 300 PPS. On non-mgmt devices, the packets should be trapped at CIR of
        100 PPS. Also ran sonic-mgmt dhcp_relay test and confirmed that it passes.
    
    Signed-off-by: Prabhat Aravind <paravind@microsoft.com>
    prabhataravind committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    e641c1e View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2024

  1. [image_config]: Address review comments

     * Modify condition check for Mgmt devices
    
    Signed-off-by: Prabhat Aravind <paravind@microsoft.com>
    prabhataravind committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    db1e806 View commit details
    Browse the repository at this point in the history