-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use only active ports when applying buffers/qos configuration #1787
Merged
pavel-shirshov
merged 6 commits into
sonic-net:master
from
pavel-shirshov:pavelsh/qos_ports
Jun 21, 2018
Merged
Use only active ports when applying buffers/qos configuration #1787
pavel-shirshov
merged 6 commits into
sonic-net:master
from
pavel-shirshov:pavelsh/qos_ports
Jun 21, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I would like to see a unit test for this. better to add this to sonic-cfggen unit test. |
lguohan
requested changes
Jun 20, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing sonic-cfggen unit test
lguohan
approved these changes
Jun 21, 2018
lguohan
pushed a commit
that referenced
this pull request
Sep 9, 2021
To include sonic_installer swap setup changes 171eb4f [sonic_installer] Add swap setup support (#1787) 6483b0b QOS fieldvalue refernce ABNF format to string (#1626) 8d16eb5 [Fast-reboot] Set flex counters delay indicator to prevent flex counters enablement after fast-reboot (#1768) 1bc24ca [portstat pfcstat] Unify the packet number format in the output of portstat and pfcstat in all cases (#1755) d7900dd [config][generic-update] Implementing patch sorting (2nd attempt) (#1794) 7ed9a91 [show] Allow system with no ports in config db run without errors (#1754) Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
taras-keryk
pushed a commit
to taras-keryk/sonic-buildimage
that referenced
this pull request
Apr 28, 2022
What I did Let's add swap memory setup support for sonic_installer command so it could run on devices with limited memory resources. How I did it Add the following new options to sonic_installer: * --skip-setup-swap: if present, will skip setup swap memory. * --swap-mem-size: this will change the swap memory size(the default swap size is 1024 MiB) * --total-mem-threshold: if the system total memory is less than the value passed to --total-mem-threshold(default 2048 MiB), sonic_installer will setup swap memory. * --available-mem-threshold: if the system available memory is less than the value passed to --available-mem-threshold(default 1200 MiB), sonic_installer will setup swap memory. Add class MutuallyExclusiveOption to check the mutually-exclusive relationship between options. Add class SWAPAllocator to support swap memory setup/remove functionalities. NOTE: when sonic_installer tries to setup swap, if the system disk free space is less than 4096 MiB, sonic_installer will not setup swap memory. How to verify it Run sonic_installer over devices with limited memory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
Build an image and test on DUT
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)