Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use only active ports when applying buffers/qos configuration #1787

Merged
merged 6 commits into from
Jun 21, 2018

Conversation

pavel-shirshov
Copy link
Contributor

- What I did

  1. Renamed all qos.json, to qos.json.j2 to be able change them.
  2. Added a logic into qos template for Dell S6100 to render this file with active ports only.
  3. Added a logic into buffer.json.j2 for all platforms to render it with active ports only.
  4. This change depended on Render qos.json.j2 from a template sonic-utilities#266 which must be added to this PR as soon as it will be added to master.

- How I did it

- How to verify it
Build an image and test on DUT

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@lguohan
Copy link
Collaborator

lguohan commented Jun 13, 2018

I would like to see a unit test for this. better to add this to sonic-cfggen unit test.

Copy link
Collaborator

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing sonic-cfggen unit test

@pavel-shirshov pavel-shirshov merged commit 3681cfa into sonic-net:master Jun 21, 2018
@pavel-shirshov pavel-shirshov deleted the pavelsh/qos_ports branch June 21, 2018 18:51
lguohan pushed a commit that referenced this pull request Sep 9, 2021
To include sonic_installer swap setup changes

171eb4f [sonic_installer] Add swap setup support (#1787)
6483b0b QOS fieldvalue refernce ABNF format to string (#1626)
8d16eb5 [Fast-reboot] Set flex counters delay indicator to prevent flex counters enablement after fast-reboot (#1768)
1bc24ca [portstat pfcstat] Unify the packet number format in the output of portstat and pfcstat in all cases (#1755)
d7900dd [config][generic-update] Implementing patch sorting (2nd attempt) (#1794)
7ed9a91 [show] Allow system with no ports in config db run without errors (#1754)

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
taras-keryk pushed a commit to taras-keryk/sonic-buildimage that referenced this pull request Apr 28, 2022
What I did
Let's add swap memory setup support for sonic_installer command so it could run on devices with limited memory resources.

How I did it
Add the following new options to sonic_installer:
* --skip-setup-swap: if present, will skip setup swap memory.
* --swap-mem-size: this will change the swap memory size(the default swap size is 1024 MiB)
* --total-mem-threshold: if the system total memory is less than the value passed to --total-mem-threshold(default 2048 MiB), sonic_installer will setup swap memory.
* --available-mem-threshold: if the system available memory is less than the value passed to --available-mem-threshold(default 1200 MiB), sonic_installer will setup swap memory.
Add class MutuallyExclusiveOption to check the mutually-exclusive relationship between options.
Add class SWAPAllocator to support swap memory setup/remove functionalities.
NOTE: when sonic_installer tries to setup swap, if the system disk free space is less than 4096 MiB, sonic_installer will not setup swap memory.

How to verify it
Run sonic_installer over devices with limited memory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants