Enable sairedis counter thread in 3 minutes after SONiC was started #1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the purpose? |
|
Delay cpu consuming service start which is not required until SONiC is started. |
lguohan
approved these changes
Jun 23, 2018
5 tasks
wen587
added a commit
that referenced
this pull request
Oct 26, 2021
8ea834b [sonic_installer] Change sonic_installer check ASIC mismatch by platforms list (#1836) 9017d99 Fix the option missing in kernel config issue (#1888) 6595ad4 [mlag] fix log print sequence (#1730) e600e1c CLI command to load config in Yang format (#1781) 00948d0 Fix the target db version of portchannel-key test (#1842) 6412fea [sonic-package-manager] remove make_python_identifier (#1801) f738818 [sonic-package-manager] stop service explicitelly before uninstalling package (#1805) d8ee5e9 Remove exec from platform_reboot_plugin call to handle any hang issue. (#1879) 827fcee [chassis][routecheck]filter out the chassis internal interfaces (#1798) 4d732c6 [generic_config_updater] Logging (#1864) 25bb184 [config]: Add loopback interfaces to interface name checker (#1869) c950a55 Validate input of config mirror_session add (#1825) 9ab20fd [show][config] fix the muxcable commands for interface naming mode (#1862) 476b3a4 [multi-asic][cli][chassis-db] Avoid connecting to chassis db for cli commands executed from linecard (#1707)
taras-keryk
pushed a commit
to taras-keryk/sonic-buildimage
that referenced
this pull request
Apr 28, 2022
… package (sonic-net#1805) #### What I did Fixed an issue with uninstall. 1. When disabling the feature by setting its state to disabled in FEATURE table and then uninstalling it, there is a possibility that service hasn't fully stopped yet. 2. When uninstalling with --force option, and reinstalling the package with --enable option the service does not start. #### How I did it Stop and disable service explicitely before uninstalling package. #### How to verify it ``` sudo spm uninstall cpu-report --force && sudo spm install cpu-report=10.0.0 -v DEBUG -y --enable && docker ps ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Add functionality to delay starting counter thread and snmp service.
The counter thread will be enabled in 3 minutes after SONiC has been started. The snmp service will be started in 30 seconds later of the counter thread.
- How I did it
Using Sihui's changes in swss and sairedis and modifying systemd configuration.
- How to verify it
Build an image and run on DUT. Right after the start you should see that snmp is not running and
redis-cli monitor doesn't show any counter upgrades.
The counter will be started in 180 sec (you can check by redis-cli monitor) and snmp will be started in 210 sec.
You can check the timer status by
sudo systemctl list-timers --all.You can check the services status by
sudo systemctl status snmp.serviceandsudo systemctl status enable_counter.service- Description for the changelog
Delay start of counter thread and snmp service.
- A picture of a cute animal (not mandatory but encouraged)