[202305] update frr patch for bgpd-Ensure-community-data-is-freed-in-some-cases #18246
Conversation
|
@StormLiangMS the change looks good. but I thought patch 38 can be merged with patch 37 as it has been taken? |
Agree with Ying. I would prefer to have a single patch. Can we update? |
| - bgp_adj_out_set_subgroup( | ||
| - dest, subgrp, &attr, selected); | ||
| - else | ||
| + if (!bgp_check_withdrawal(bgp, dest)) { |
There was a problem hiding this comment.
Can you please check the latest update on FRRouting/frr#15466 ? The diff has changed in this file
There was a problem hiding this comment.
Can you please check the latest update on FRRouting/frr#15466 ? The diff has changed in this file
HI, @dgsudharsan thanks for reviewing the code. This part of the code should be the same, the difference should be related to the difference between 202305 branch and master. thanks.
| if (dest) { | ||
| for (pi = bgp_dest_get_bgp_path_info(dest); pi; | ||
| pi = pi->next) { | ||
| - if (CHECK_FLAG(pi->flags, BGP_PATH_SELECTED)) |
There was a problem hiding this comment.
Can you please check the original PR for this file as well? The diff is little bit different
There was a problem hiding this comment.
Can you please check the original PR for this file as well? The diff is little bit different
Yes, this diff was based on our understanding. we will sync with donaldsharp first, and push the latest update if necessary later, thanks.
|
PR test pending due to maintainess, bypass the not finished test. |
Why I did it
FRR issue
FRRouting/frr#15459
Add patch for FRR PR for 202305
FRRouting/frr#15466
Work item tracking
How I did it
Add patch for FRR PR
FRRouting/frr#15466
How to verify it
Run the original case locally
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)