[e1031] replace host check command in celestica e1031 #18279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ADO 27085874 |
prgeor
approved these changes
Mar 7, 2024
saiarcot895
reviewed
Mar 7, 2024
| return True for host and False for docker | ||
| """ | ||
| docker_env_file = '/.dockerenv' | ||
| return os.path.exists(docker_env_file) is False |
There was a problem hiding this comment.
Minor change: os.path.exists(docker_env_file) is False -> not os.path.exists(docker_env_file)
saiarcot895
approved these changes
Mar 7, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Mar 7, 2024
|
Cherry-pick PR to 202311: #18298 |
mssonicbld
pushed a commit
that referenced
this pull request
Mar 7, 2024
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Mar 8, 2024
|
Cherry-pick PR to 202305: #18309 |
sonic-otn
pushed a commit
to Weitang-Zheng/sonic-buildimage
that referenced
this pull request
Mar 11, 2024
mssonicbld
pushed a commit
that referenced
this pull request
Mar 12, 2024
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
saksarav-nokia
pushed a commit
to saksarav-nokia/sonic-buildimage
that referenced
this pull request
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
The original host check command docker will hang indefinitely when it is run too early in the boot process, halting determine-reboot-cause and lldp/pmon/snmp service from starting. Replace docker with checking /.dockerenv existence.
Work item tracking
How I did it
Replace docker with checking /.dockerenv existence.
How to verify it
Manually modify image and reboot to see if everything work
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
202305.18
Description for the changelog
Replace host check command for celestica e1031
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)