Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox][SN4410] Add missing interfaces to hwsku #18791

Merged

Conversation

ayurkiv-nvda
Copy link
Contributor

@ayurkiv-nvda ayurkiv-nvda commented Apr 24, 2024

Why I did it

Logic of config generation changed recently
Command : sonic-cfggen -H -k ACS-MSN4410 --preset t1 will fail after ONIE installation.
There are missing interfaces for 4410 HWSKU. Need to add them.

Work item tracking
  • Microsoft ADO (number only):

How I did it

Update file device/mellanox/x86_64-mlnx_msn4410-r0/ACS-MSN4410/hwsku.json

How to verify it

sonic-cfggen -H -k ACS-MSN4410 --preset t1 will pass successfully on 4410 platform after ONIE installation.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305
  • 202311

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ayurkiv-nvda ayurkiv-nvda force-pushed the 4410_hwsku_update_public branch from 79c2499 to b0daeb5 Compare April 29, 2024 12:04
@ayurkiv-nvda
Copy link
Contributor Author

/azp run Azure.sonic-buildimage (Test kvmtest-t0 by Elastictest)

Copy link

Commenter does not have sufficient privileges for PR 18791 in repo sonic-net/sonic-buildimage

@ayurkiv-nvda
Copy link
Contributor Author

ayurkiv-nvda commented Apr 29, 2024

Azure.sonic-buildimage (Test kvmtest-t0 by Elastictest) failed with following error:

generic_config_updater/test_syslog.py

stdout_lines	
	:	Patch Applier: localhost: Patch application starting.
	:	Patch Applier: localhost: Patch: [{\"op\": \"add\", \"path\": \"/SYSLOG_SERVER/-badhostname\", \"value\": {}}, {\"op\": \"add\", \"path\": \"/SYSLOG_SERVER/cc98:2008::1\", \"value\": {}}]
	:	Patch Applier: localhost getting current config db.
	:	Patch Applier: localhost: simulating the target full config after applying the patch.
	:	Patch Applier: localhost: validating all JsonPatch operations are permitted on the specified fields
	:	Patch Applier: localhost: alidating target config does not have empty tables, since they do not show up in ConfigDb.
	:	Patch Applier: localhost: sorting patch updates.
stderr_lines
	:	Failed to apply patch due to: Failed to apply patch on the following scopes:
	:	- localhost: Given patch will produce invalid config. Error: Data Loading Failed
	:	Invalid value \"-badhostname\" in \"server_address\" element.
	:	Usage: config apply-patch [OPTIONS] PATCH_FILE_PATH
	:	Try \"config apply-patch -h\" for help.
	:	
	:	Error: Failed to apply patch on the following scopes:
	:	- localhost: Given patch will produce invalid config. Error: Data Loading Failed
	:	Invalid value \"-badhostname\" in \"server_address\" element.
Apr 29 14:32:15.144469 vlab-01 ERR sonic_yang: Data Loading Failed:Invalid value "cc98:2008::xyz" in "server_address" element.
Apr 29 14:32:15.144931 vlab-01 ERR config: 'apply-patch' executed failed for localhost by [{'op': 'add', 'path': '/SYSLOG_SERVER/goodhostname', 'value': {}}, {'op': 'add', 'path': '/SYSLOG_SERVER/cc98:2008::xyz', 'value': {}}] due to Given patch will produce invalid config. Error: Data Loading Failed#012Invalid value "cc98:2008::xyz" in "server_address" element.
Apr 29 14:32:18.869084 vlab-01 ERR GenericConfigUpdater: 'apply-patch' executed failed for localhost by [{'op': 'remove', 'path': '/SYSLOG_SERVER/10.0.0.6', 'value': {}}, {'op': 'remove', 'path': '/SYSLOG_SERVER/cc98:2008:1', 'value': {}}] due to can't remove a non-existent object '10.0.0.6'
Apr 29 14:32:22.433045 vlab-01 ERR GenericConfigUpdater: 'apply-patch' executed failed for localhost by [{'op': 'remove', 'path': '/SYSLOG_SERVER/10.0.0.5', 'value': {}}, {'op': 'remove', 'path': '/SYSLOG_SERVER/cc98:2008::2', 'value': {}}] due to can't remove a non-existent object 'cc98:2008::2'

It does not look like related to this PR, seems like it is another issue

@ayurkiv-nvda ayurkiv-nvda force-pushed the 4410_hwsku_update_public branch from b0daeb5 to 6f27d3f Compare April 29, 2024 21:18
Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>
@ayurkiv-nvda ayurkiv-nvda force-pushed the 4410_hwsku_update_public branch from 6f27d3f to f15a46e Compare April 30, 2024 18:26
@keboliu keboliu requested a review from liat-grozovik May 7, 2024 06:51
@liat-grozovik
Copy link
Collaborator

/azpw run Azure.sonic-buildimage

@liat-grozovik liat-grozovik merged commit 4839a7b into sonic-net:master May 7, 2024
19 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request May 21, 2024
- Why I did it
Logic of config generation changed recently
Command : sonic-cfggen -H -k ACS-MSN4410 --preset t1  will fail after ONIE installation.
There are missing interfaces for 4410 HWSKU. Need to add them.

- How I did it
Update file device/mellanox/x86_64-mlnx_msn4410-r0/ACS-MSN4410/hwsku.json

- How to verify it
sonic-cfggen -H -k ACS-MSN4410 --preset t1 will pass successfully on 4410 platform after ONIE installation.

Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #19033

mssonicbld pushed a commit that referenced this pull request May 22, 2024
- Why I did it
Logic of config generation changed recently
Command : sonic-cfggen -H -k ACS-MSN4410 --preset t1  will fail after ONIE installation.
There are missing interfaces for 4410 HWSKU. Need to add them.

- How I did it
Update file device/mellanox/x86_64-mlnx_msn4410-r0/ACS-MSN4410/hwsku.json

- How to verify it
sonic-cfggen -H -k ACS-MSN4410 --preset t1 will pass successfully on 4410 platform after ONIE installation.

Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants