-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mellanox][SN4410] Add missing interfaces to hwsku #18791
Merged
liat-grozovik
merged 1 commit into
sonic-net:master
from
ayurkiv-nvda:4410_hwsku_update_public
May 7, 2024
Merged
[Mellanox][SN4410] Add missing interfaces to hwsku #18791
liat-grozovik
merged 1 commit into
sonic-net:master
from
ayurkiv-nvda:4410_hwsku_update_public
May 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
vadymhlushko-mlnx
approved these changes
Apr 26, 2024
ayurkiv-nvda
force-pushed
the
4410_hwsku_update_public
branch
from
April 29, 2024 12:04
79c2499
to
b0daeb5
Compare
/azp run Azure.sonic-buildimage (Test kvmtest-t0 by Elastictest) |
Commenter does not have sufficient privileges for PR 18791 in repo sonic-net/sonic-buildimage |
Azure.sonic-buildimage (Test kvmtest-t0 by Elastictest) failed with following error: generic_config_updater/test_syslog.py
It does not look like related to this PR, seems like it is another issue |
ayurkiv-nvda
force-pushed
the
4410_hwsku_update_public
branch
from
April 29, 2024 21:18
b0daeb5
to
6f27d3f
Compare
Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>
ayurkiv-nvda
force-pushed
the
4410_hwsku_update_public
branch
from
April 30, 2024 18:26
6f27d3f
to
f15a46e
Compare
/azpw run Azure.sonic-buildimage |
liat-grozovik
approved these changes
May 7, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
May 21, 2024
- Why I did it Logic of config generation changed recently Command : sonic-cfggen -H -k ACS-MSN4410 --preset t1 will fail after ONIE installation. There are missing interfaces for 4410 HWSKU. Need to add them. - How I did it Update file device/mellanox/x86_64-mlnx_msn4410-r0/ACS-MSN4410/hwsku.json - How to verify it sonic-cfggen -H -k ACS-MSN4410 --preset t1 will pass successfully on 4410 platform after ONIE installation. Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>
Cherry-pick PR to 202311: #19033 |
mssonicbld
pushed a commit
that referenced
this pull request
May 22, 2024
- Why I did it Logic of config generation changed recently Command : sonic-cfggen -H -k ACS-MSN4410 --preset t1 will fail after ONIE installation. There are missing interfaces for 4410 HWSKU. Need to add them. - How I did it Update file device/mellanox/x86_64-mlnx_msn4410-r0/ACS-MSN4410/hwsku.json - How to verify it sonic-cfggen -H -k ACS-MSN4410 --preset t1 will pass successfully on 4410 platform after ONIE installation. Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Logic of config generation changed recently
Command :
sonic-cfggen -H -k ACS-MSN4410 --preset t1 will fail after ONIE installation.
There are missing interfaces for 4410 HWSKU. Need to add them.
Work item tracking
How I did it
Update file device/mellanox/x86_64-mlnx_msn4410-r0/ACS-MSN4410/hwsku.json
How to verify it
sonic-cfggen -H -k ACS-MSN4410 --preset t1
will pass successfully on 4410 platform after ONIE installation.Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)