Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bmp container init workflow. #18946

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

FengPan-Frank
Copy link
Contributor

@FengPan-Frank FengPan-Frank commented May 13, 2024

Why I did it

Add bmp container init workflow.

Work item tracking
  • Microsoft ADO (number only):27588893

How I did it

Add bmp container which is disabled by INCLUDE_BMP = n for now, which would cause container not build by default. This will be enabled as last step.

Add INCLUDE_BMP to indicate whether to build bmp container
Add docker file for bmp, as well as agent used openbmpd/bmpcfgd.
Add template file for bmp container services.

How to verify it

Build image with INCLUDE_BMP = y to verify, Image should be install correctly. By config feature state bmp enabled to enable.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@FengPan-Frank
Copy link
Contributor Author

/azp run Azure.sonic-buildimage

Copy link

Commenter does not have sufficient privileges for PR 18946 in repo sonic-net/sonic-buildimage

@FengPan-Frank
Copy link
Contributor Author

/azpw ms_conflict

rules/config Outdated Show resolved Hide resolved
@lguohan lguohan added the BMP Bgp Monitor Container label May 18, 2024
@forrestchu
Copy link

Why I did it

Add bmp container init workflow.

Work item tracking
  • Microsoft ADO (number only):27588893

How I did it

Add bmp container which is disabled by INCLUDE_BMP = n for now, which would cause container not build by default. This will be enabled as last step.

Add INCLUDE_BMP to indicate whether to build bmp container Add docker file for bmp, as well as agent used openbmpd/bmpcfgd. Add template file for bmp container services. Add entry for bmp to FEATURE table in config_db.

How to verify it

Build image with INCLUDE_BMP = y to verify, Image should be install correctly. By config feature state bmp enabled to enable.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

  • [ ]
  • [ ]

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Hi Frank, which TCP port will this bmp server use by default? Is it configurable from config_db or CLI?

@FengPan-Frank
Copy link
Contributor Author

FengPan-Frank commented Nov 7, 2024

Why I did it

Add bmp container init workflow.

Work item tracking
  • Microsoft ADO (number only):27588893

How I did it

Add bmp container which is disabled by INCLUDE_BMP = n for now, which would cause container not build by default. This will be enabled as last step.
Add INCLUDE_BMP to indicate whether to build bmp container Add docker file for bmp, as well as agent used openbmpd/bmpcfgd. Add template file for bmp container services. Add entry for bmp to FEATURE table in config_db.

How to verify it

Build image with INCLUDE_BMP = y to verify, Image should be install correctly. By config feature state bmp enabled to enable.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

  • [ ]
  • [ ]

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Hi Frank, which TCP port will this bmp server use by default? Is it configurable from config_db or CLI?

it's 5000, pls refer HLD section https://github.com/sonic-net/SONiC/blob/50cb55989649d5392b48b54bb7ca8263c883e162/doc/bmp/bmp.md#config-file-update

DOCKER_EXEC_FLAGS+="t"
fi

docker exec -$DOCKER_EXEC_FLAGS bmp redis-cli "$@"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why you use this file?

Copy link
Contributor

@xincunli-sonic xincunli-sonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BMP Bgp Monitor Container
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants