Update save disable code for new Redis version #18979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the upgrade of docker-database to Bookworm and the new Redis version that was brought in, database saves are enabled by default. However, we don't use (and maybe don't want, at this time) those database saves. Restore the old behavior by modifying `/etc/redis/redis.conf` to not save at all. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
|
/azpw ms_conflict |
|
@saiarcot895 : I assume this should fix this: #18667 |
|
@abdosi Yes, this will fix that. I didn't realize there was already an impact here. |
can we add some UT to catch this as this is major behavior change |
|
@saiarcot895 , can you check the conflict? |
8 tasks
It's saying that a conflict already exists in master, and to wait a few hours and rerun the conflict checker.
Opened sonic-net/sonic-mgmt#12877. |
|
/azpw ms_conflict |
1 similar comment
|
/azpw ms_conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
With the upgrade of docker-database to Bookworm in #18108 and the new Redis version that was brought in, database saves are enabled by default. However, we don't use (and maybe don't want, at this time) those database saves.
Work item tracking
How I did it
Restore the old behavior by modifying
/etc/redis/redis.confto not save at all.How to verify it
Checked
/var/log/syslogto make sure there weren't messages from redis every minute saying the database was being saved, and verified/etc/redis/redis.confin the database container has a config line withsave "".Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)