Add new redis database instance for BMP_STATE_DB. #19016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 20, 2024
qiluo-msft
reviewed
May 20, 2024
qiluo-msft
reviewed
May 21, 2024
qiluo-msft
previously approved these changes
May 23, 2024
|
/azp run Azure.sonic-buildimage |
|
Commenter does not have sufficient privileges for PR 19016 in repo sonic-net/sonic-buildimage |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
reviewed
Aug 29, 2024
| @@ -130,6 +136,18 @@ | |||
| "instance" : {% if include_remote_db %} "remote_redis" {% else %} "redis" {% endif %} | |||
| } | |||
| {% endif %} | |||
| , | |||
| "EVENT_DB" : { | |||
There was a problem hiding this comment.
@zbud-msft do you have any idea?
qiluo-msft
reviewed
Aug 29, 2024
| @@ -41,14 +41,16 @@ then | |||
| fi | |||
| fi | |||
|
|
|||
| export BMP_DB_PORT=6400 | |||
There was a problem hiding this comment.
@Pterosaur How to ensure this port is not conflicting with REMOTE_DB_PORT? or does it matter?
qiluo-msft
reviewed
Aug 29, 2024
rules/docker-restapi.mk
Outdated
| @@ -29,6 +29,7 @@ endif | |||
| $(DOCKER_RESTAPI)_CONTAINER_NAME = restapi | |||
| $(DOCKER_RESTAPI)_RUN_OPT += -t | |||
| $(DOCKER_RESTAPI)_RUN_OPT += -v /var/run/redis/redis.sock:/var/run/redis/redis.sock | |||
| $(DOCKER_RESTAPI)_RUN_OPT += -v /var/run/redis/redis_bmp.sock:/var/run/redis/redis_bmp.sock | |||
zbud-msft
reviewed
Sep 3, 2024
| @@ -11,6 +11,11 @@ | |||
| "port": 6380, | |||
| "unix_socket_path": "/var/run/redis/redis_chassis.sock" | |||
| } | |||
| ,"redis_bmp":{ | |||
There was a problem hiding this comment.
nit: Can we put comma at the end of the previous section?
| @@ -77,6 +82,11 @@ | |||
| "id" : 14, | |||
| "separator": ":", | |||
| "instance" : "redis" | |||
| }, | |||
| "BMP_STATE_DB" : { | |||
| "id" : 20, | |||
There was a problem hiding this comment.
Why is new database id 20 vs next in sequence 15?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Add new redis database instance for BMP_STATE_DB. since bmp data set will be a bit large which we don't want block existing state_db operation.
Work item tracking
How I did it
Changed database config and will use it into bmp relevant PR.
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)