-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wred drop probability config in qos wred profile #1913
Conversation
Signed-off-by: Wenda <wenni@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you need to fix the test too. Maybe consider using the default value approach?
What is the downside if we don't config them?
Signed-off-by: Wenda <wenni@microsoft.com>
It will use the hardware default drop probability 0% |
commented on the other pr in swss, we do not need this if we keep the default value in swss to be 100. |
a0bff26 [acl-loader] modify acl-loader with change in STATE DB ACL capability table (sonic-net#1896) a395e28 [debug dump util] Changes for EVPN and VxLAN dump module (sonic-net#1892) 02a98ef [debug dump util] Route Module added (sonic-net#1913) ac8382f [generic-config-updater] Logging change just before applying it (sonic-net#1934) 9ab6c51 [flex counter] Flex counter threads consume too much CPU resources. sonic-net#9202 (sonic-net#1925) 2ec47a5 [generic-config-updater] Handling empty tables while sorting a patch (sonic-net#1923) fdedcbf [fdbshow]: Handle FDB cleanup gracefully. (sonic-net#1926) e7535ae [sonic-cli-gen] first phase implementation of the SONiC CLI Auto-generation tool (sonic-net#1644) Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
a0bff26 [acl-loader] modify acl-loader with change in STATE DB ACL capability table (#1896) a395e28 [debug dump util] Changes for EVPN and VxLAN dump module (#1892) 02a98ef [debug dump util] Route Module added (#1913) ac8382f [generic-config-updater] Logging change just before applying it (#1934) 9ab6c51 [flex counter] Flex counter threads consume too much CPU resources. #9202 (#1925) 2ec47a5 [generic-config-updater] Handling empty tables while sorting a patch (#1923) fdedcbf [fdbshow]: Handle FDB cleanup gracefully. (#1926) e7535ae [sonic-cli-gen] first phase implementation of the SONiC CLI Auto-generation tool (#1644) Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
* Added the Route Module to the Debug Dump Utility Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
Signed-off-by: Wenda wenni@microsoft.com
- What I did
- How I did it
- How to verify it
Tested on one brcm dut with sonic-net/sonic-swss#571
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)