Include unresolved neighbors when comparing APPL_DB and kernel neighbors #19164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
kperumalbfn
reviewed
Jun 3, 2024
| KERNEIGH4=$(ip -4 neigh show | grep Vlan | grep -v 'FAILED\|INCOMPLETE' | cut -d ' ' -f 1,3 --output-delimiter=',') | ||
| KERNEIGH6=$(ip -6 neigh show | grep -v fe80 | grep Vlan | grep -v 'FAILED\|INCOMPLETE' | cut -d ' ' -f 1,3 --output-delimiter=',') | ||
| KERNEIGH4=$(ip -4 neigh show | grep Vlan | cut -d ' ' -f 1,3 --output-delimiter=',') | ||
| KERNEIGH6=$(ip -6 neigh show | grep -v fe80 | grep Vlan | cut -d ' ' -f 1,3 --output-delimiter=',') |
There was a problem hiding this comment.
Is this change required only for dual-tors? This change looks common for all devices.
There was a problem hiding this comment.
05a85b5 introduced this change originally, before that commit this was the behavior for all devices.
There was a problem hiding this comment.
Backport to other branches? 202305 and 202311?
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
approved these changes
Jun 5, 2024
|
@kperumalbfn , would you signoff and merge? |
kperumalbfn
approved these changes
Jun 5, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jun 7, 2024
…ors (sonic-net#19164) Signed-off-by: Lawrence Lee <lawlee@microsoft.com> Include unresolved neighbors when comparing APPL_DB and kernel neighbors.
|
Cherry-pick PR to 202305: #19245 |
mssonicbld
pushed a commit
that referenced
this pull request
Jun 7, 2024
…ors (#19164) Signed-off-by: Lawrence Lee <lawlee@microsoft.com> Include unresolved neighbors when comparing APPL_DB and kernel neighbors.
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
arun1355492
pushed a commit
to arun1355492/sonic-buildimage
that referenced
this pull request
Jul 26, 2024
…ors (sonic-net#19164) Signed-off-by: Lawrence Lee <lawlee@microsoft.com> Include unresolved neighbors when comparing APPL_DB and kernel neighbors.
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Aug 2, 2024
…ors (sonic-net#19164) Signed-off-by: Lawrence Lee <lawlee@microsoft.com> Include unresolved neighbors when comparing APPL_DB and kernel neighbors.
|
Cherry-pick PR to 202311: #19794 |
mssonicbld
pushed a commit
that referenced
this pull request
Aug 3, 2024
…ors (#19164) Signed-off-by: Lawrence Lee <lawlee@microsoft.com> Include unresolved neighbors when comparing APPL_DB and kernel neighbors.
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
bingwang-ms
added
Approved for 202405 Branch
and removed
Approved for 202405 Branch
labels
bingwang-ms
added
Approved for 202405 Branch
and removed
Approved for 202405 Branch
labels
bingwang-ms
added
Approved for 202405 Branch
and removed
Approved for 202405 Branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Sep 20, 2024
…ors (sonic-net#19164) Signed-off-by: Lawrence Lee <lawlee@microsoft.com> Include unresolved neighbors when comparing APPL_DB and kernel neighbors.
|
Cherry-pick PR to 202405: #20321 |
mssonicbld
pushed a commit
that referenced
this pull request
Sep 21, 2024
…ors (#19164) Signed-off-by: Lawrence Lee <lawlee@microsoft.com> Include unresolved neighbors when comparing APPL_DB and kernel neighbors.
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
On dual TOR devices, excluding INCOMPLETE and FAILED neighbors when checking for neighbor mismatches between APPL_DB and the kernel will result in all zero MAC neighbors being logged as mismatches.
Work item tracking
How I did it
How to verify it
On a dual TOR device, add a FAILED neighbor entry (can simply
pingsome unreachable IP in the VLAN subnet).Without the changes, we would expect to see the following log every 5 minutes:
With the changes, we would not see the above log
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)