Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Reliable TSA implementation" - Unblock PR test #19173

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Revert "Reliable TSA implementation" - Unblock PR test #19173

merged 1 commit into from
Jun 3, 2024

Conversation

bingwang-ms
Copy link
Contributor

@bingwang-ms bingwang-ms commented Jun 2, 2024 •
edited
Loading

Reverts #18928

The change caused exception in bgpcfgd, which blocks all PR testing in sonic-buildimage repo.

2024 Jun  2 21:53:03.258965 str-msn2700a1-03 ERR bgp#bgpcfgd: :- getDbInfo: Failed to find CHASSIS_APP_DB database in : key
2024 Jun  2 21:53:03.260929 str-msn2700a1-03 CRIT bgp#bgpcfgd: Got an exception Failed to find CHASSIS_APP_DB database in : key: Traceback: Traceback (most recent call last):#012  File "/usr/local/lib/python3.9/dist-packages/bgpcfgd/main.py", line 92, in main#012    do_work()#012  File "/usr/local/lib/python3.9/dist-packages/bgpcfgd/main.py", line 81, in do_work#012    runner.add_manager(mgr)#012  File "/usr/local/lib/python3.9/dist-packages/bgpcfgd/runner.py", line 40, in add_manager#012    db = swsscommon.SonicDBConfig.getDbId(db_name)#012  File "/usr/lib/python3/dist-packages/swsscommon/swsscommon.py", line 1716, in getDbId#012    return _swsscommon.SonicDBConfig_getDbId(*args)#012IndexError: Failed to find CHASSIS_APP_DB database in : key
2024 Jun  2 21:53:03.261239 str-msn2700a1-03 INFO bgp#supervisord: bgpcfgd Traceback (most recent call last):
2024 Jun  2 21:53:03.261570 str-msn2700a1-03 INFO bgp#supervisord: bgpcfgd   File "/usr/local/bin/bgpcfgd", line 8, in <module>
2024 Jun  2 21:53:03.262050 str-msn2700a1-03 INFO bgp#supervisord: bgpcfgd     sys.exit(main())
2024 Jun  2 21:53:03.262357 str-msn2700a1-03 INFO bgp#supervisord: bgpcfgd   File "/usr/local/lib/python3.9/dist-packages/bgpcfgd/main.py", line 92, in main
2024 Jun  2 21:53:03.262848 str-msn2700a1-03 INFO bgp#supervisord: bgpcfgd     do_work()
2024 Jun  2 21:53:03.263142 str-msn2700a1-03 INFO bgp#supervisord: bgpcfgd   File "/usr/local/lib/python3.9/dist-packages/bgpcfgd/main.py", line 81, in do_work
2024 Jun  2 21:53:03.263643 str-msn2700a1-03 INFO bgp#supervisord: bgpcfgd     runner.add_manager(mgr)
2024 Jun  2 21:53:03.263958 str-msn2700a1-03 INFO bgp#supervisord: bgpcfgd   File "/usr/local/lib/python3.9/dist-packages/bgpcfgd/runner.py", line 40, in add_manager
2024 Jun  2 21:53:03.264444 str-msn2700a1-03 INFO bgp#supervisord: bgpcfgd     db = swsscommon.SonicDBConfig.getDbId(db_name)
2024 Jun  2 21:53:03.264745 str-msn2700a1-03 INFO bgp#supervisord: bgpcfgd   File "/usr/lib/python3/dist-packages/swsscommon/swsscommon.py", line 1716, in getDbId
2024 Jun  2 21:53:03.265765 str-msn2700a1-03 INFO bgp#supervisord: bgpcfgd     return _swsscommon.SonicDBConfig_getDbId(*args)
2024 Jun  2 21:53:03.266099 str-msn2700a1-03 INFO bgp#supervisord: bgpcfgd IndexError: Failed to find CHASSIS_APP_DB database in : key

lolyu
lolyu approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@lolyu lolyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bingwang-ms bingwang-ms changed the title Revert "Reliable TSA implementation" Revert "Reliable TSA implementation" - Unblock PR test Jun 3, 2024
@yxieca yxieca merged commit ab08b78 into master Jun 3, 2024
20 checks passed
@yxieca yxieca deleted the revert-18928-Reliable-TSA branch June 3, 2024 15:48
@fountzou fountzou mentioned this pull request Jun 5, 2024
Merged
11 tasks
arun1355492 pushed a commit to arun1355492/sonic-buildimage that referenced this pull request Jul 26, 2024
@bingwang-ms @arun1355492
Revert "Reliable TSA implementation (sonic-net#18928)" (sonic-net#19173)
2fe3529 
This reverts commit 9d5fb20.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolyu lolyu lolyu approved these changes

@StormLiangMS StormLiangMS Awaiting requested review from StormLiangMS StormLiangMS is a code owner

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bingwang-ms @lolyu @yxieca