-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bcmsh]: add inactivity timeout for bcmsh (default 300 seconds) #1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guohan Lu <gulv@microsoft.com>
jleveque
approved these changes
Aug 13, 2018
qiluo-msft
approved these changes
Aug 13, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain the behavior before this PR?
mellanox build failure is caused by an unrelated issue #1924 . |
5 tasks
prsunny
added a commit
that referenced
this pull request
Sep 27, 2021
vivekrnv
added a commit
to vivekrnv/sonic-buildimage
that referenced
this pull request
Nov 16, 2021
…t#1796) efa2ff6 [show][platform summary] Add chassis type in the platform summary output(sonic-net#1922) a39350c [aclshow] enhance ACL counters to work with FC infrastructure (sonic-net#1858) ed88013 [sonic-package-manager] fix registry requests failing when no service field in Bearer fields (sonic-net#1921) 00b6045 [VS test] Increase test timeout (sonic-net#1924) Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
qiluo-msft
pushed a commit
that referenced
this pull request
Nov 22, 2021
a3e34e3 [Auto Techsupport] Event driven Techsupport Changes (#1796) efa2ff6 [show][platform summary] Add chassis type in the platform summary output(#1922) a39350c [aclshow] enhance ACL counters to work with FC infrastructure (#1858) ed88013 [sonic-package-manager] fix registry requests failing when no service field in Bearer fields (#1921) 00b6045 [VS test] Increase test timeout (#1924)
taras-keryk
pushed a commit
to taras-keryk/sonic-buildimage
that referenced
this pull request
Apr 28, 2022
… field in Bearer fields (sonic-net#1921) Signed-off-by: Stepan Blyschak stepanb@nvidia.com What I did If Auth service did not reply with "service" field, don't fail and request the token without it. How I did it Modified registry.py and added UT. How to verify it Tested on DUT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guohan Lu gulv@microsoft.com
- What I did
add inactivity timeout for bcmsh (default 300 seconds)
- How I did it
- How to verify it
test on DUT
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)