[database] Fix database config template for remote Redis instance #19239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgsudharsan
approved these changes
Jun 6, 2024
prsunny
approved these changes
Jun 6, 2024
|
Wondering if we can have a test for this? |
liat-grozovik
added
Request for 202405 Branch
and removed
Request for 202405 Branch
labels
|
@prsunny i suggest to include the fix in 202405. if you agree, i will add the label. |
Pterosaur
approved these changes
Jun 7, 2024
|
@prsunny and @liat-grozovik , we should not add this to 202405, for DPU it is targeted for 202411. |
arun1355492
pushed a commit
to arun1355492/sonic-buildimage
that referenced
this pull request
Jul 26, 2024
…nic-net#19239) The local Redis daemon should not run for a remote database. How I did it Do not generate a supervisord configuration entry for the remote database instances. How to verify it Compile and run the DPU image. The database container on the DPU should run Redis daemons only for local DB instances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
The template has a missing comma in the remote Redis JSON configuration. This causes an error when attempting to start the database container on the DPU in the Smart Switch.
Work item tracking
How I did it
Add missing comma
How to verify it
Compile and run the DPU SONiC image. The database container should run with no errors.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)