[Mellanox] implement state machine for always firmware control ports #19473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keboliu
approved these changes
Jul 4, 2024
|
Hi @liat-grozovik , could you please help review this? |
liat-grozovik
approved these changes
Jul 8, 2024
prgeor
pushed a commit
to prgeor/sonic-buildimage
that referenced
this pull request
Jul 18, 2024
…onic-net#19473) - Why I did it When module host management is enabled, all modules are managed by the same state machine which initializes all modules/ports. However, on 5600 and 5400, there is a type of port which we called "service port". Those ports are always under firmware control. In that case, those ports should be managed by a different state machine. This PR is to implement the state machine for always firmware control ports. - How I did it Implement a state machine for always firmware control ports. - How to verify it Manual test unit test
|
@prgeor FYI. |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jul 25, 2024
…onic-net#19473) - Why I did it When module host management is enabled, all modules are managed by the same state machine which initializes all modules/ports. However, on 5600 and 5400, there is a type of port which we called "service port". Those ports are always under firmware control. In that case, those ports should be managed by a different state machine. This PR is to implement the state machine for always firmware control ports. - How I did it Implement a state machine for always firmware control ports. - How to verify it Manual test unit test
|
Cherry-pick PR to 202311: #19688 |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jul 25, 2024
…onic-net#19473) - Why I did it When module host management is enabled, all modules are managed by the same state machine which initializes all modules/ports. However, on 5600 and 5400, there is a type of port which we called "service port". Those ports are always under firmware control. In that case, those ports should be managed by a different state machine. This PR is to implement the state machine for always firmware control ports. - How I did it Implement a state machine for always firmware control ports. - How to verify it Manual test unit test
|
Cherry-pick PR to 202405: #19689 |
mssonicbld
pushed a commit
that referenced
this pull request
Jul 25, 2024
…19473) - Why I did it When module host management is enabled, all modules are managed by the same state machine which initializes all modules/ports. However, on 5600 and 5400, there is a type of port which we called "service port". Those ports are always under firmware control. In that case, those ports should be managed by a different state machine. This PR is to implement the state machine for always firmware control ports. - How I did it Implement a state machine for always firmware control ports. - How to verify it Manual test unit test
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
mssonicbld
pushed a commit
that referenced
this pull request
Jul 25, 2024
…19473) - Why I did it When module host management is enabled, all modules are managed by the same state machine which initializes all modules/ports. However, on 5600 and 5400, there is a type of port which we called "service port". Those ports are always under firmware control. In that case, those ports should be managed by a different state machine. This PR is to implement the state machine for always firmware control ports. - How I did it Implement a state machine for always firmware control ports. - How to verify it Manual test unit test
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
arun1355492
pushed a commit
to arun1355492/sonic-buildimage
that referenced
this pull request
Jul 26, 2024
…onic-net#19473) - Why I did it When module host management is enabled, all modules are managed by the same state machine which initializes all modules/ports. However, on 5600 and 5400, there is a type of port which we called "service port". Those ports are always under firmware control. In that case, those ports should be managed by a different state machine. This PR is to implement the state machine for always firmware control ports. - How I did it Implement a state machine for always firmware control ports. - How to verify it Manual test unit test
liushilongbuaa
pushed a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Aug 1, 2024
…onic-net#19473) - Why I did it When module host management is enabled, all modules are managed by the same state machine which initializes all modules/ports. However, on 5600 and 5400, there is a type of port which we called "service port". Those ports are always under firmware control. In that case, those ports should be managed by a different state machine. This PR is to implement the state machine for always firmware control ports. - How I did it Implement a state machine for always firmware control ports. - How to verify it Manual test unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
When module host management is enabled, all modules are managed by the same state machine which initializes all modules/ports. However, on 5600 and 5400, there is a type of port which we called "service port". Those ports are always under firmware control. In that case, those ports should be managed by a different state machine. This PR is to implement the state machine for always firmware control ports.
Work item tracking
How I did it
Implement a state machine for always firmware control ports.
How to verify it
Manual test
unit test
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)