Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] CMIS host management script #19509

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

skr31
Copy link
Contributor

@skr31 skr31 commented Jul 8, 2024

Why I did it

Added a script for CMIS Host Management enabling and disabling on a running switch.
This intend to prevent issues caused by wrong configuration of the feature.
The idea is to provide a more convenient way for users to configure the feature.

Work item tracking
  • Microsoft ADO (number only):

How I did it

Add the script to /usr/bin/ that supports two options:
--enable - receives paths to config files for Port SI parameters and Module SI parameters:
media_settings.json, optics_si_settings.json, and enables the feature
--disable - disables the feature

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305
  • 202311
  • 202405

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@skr31
Copy link
Contributor Author

skr31 commented Jul 10, 2024

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik liat-grozovik merged commit 12542bf into sonic-net:master Jul 11, 2024
21 checks passed
yxieca pushed a commit that referenced this pull request Jul 12, 2024
Why I did it
Added a script for CMIS Host Management enabling and disabling.

Prevents bugs caused by wrong configuration of the feature
More convenient for costumers to configure the feature

This is PR is for 202311.
Original PR (for Master and 202405): #19509

How I did it
Add the script to /usr/bin/ that supports two options:
--enable - receives paths to config files for Port SI parameters and Module SI parameters:
media_settings.json, optics_si_settings.json, and enables the feature
--disable - disables the feature
prgeor pushed a commit to prgeor/sonic-buildimage that referenced this pull request Jul 18, 2024
- Why I did it
Added a script for CMIS Host Management enabling and disabling on a running switch.
This intend to prevent issues caused by wrong configuration of the feature.
The idea is to provide a more convenient way for users to configure the feature.

- How I did it
Add the script to /usr/bin/ that supports two options:
--enable - receives paths to config files for Port SI parameters and Module SI parameters:
media_settings.json, optics_si_settings.json, and enables the feature
--disable - disables the feature
@bingwang-ms
Copy link
Contributor

@prgeor FYI

arun1355492 pushed a commit to arun1355492/sonic-buildimage that referenced this pull request Jul 26, 2024
- Why I did it
Added a script for CMIS Host Management enabling and disabling on a running switch.
This intend to prevent issues caused by wrong configuration of the feature.
The idea is to provide a more convenient way for users to configure the feature.

- How I did it
Add the script to /usr/bin/ that supports two options:
--enable - receives paths to config files for Port SI parameters and Module SI parameters:
media_settings.json, optics_si_settings.json, and enables the feature
--disable - disables the feature
@dprital
Copy link
Collaborator

dprital commented Jul 31, 2024

@prgeor / @bingwang-ms - Can it be cherry picked to 202405 please ?

@bingwang-ms
Copy link
Contributor

I'm good to cherry-pick to 202405. But we don't need it for 202311 as we don't have CMIS in 202311.

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Jul 31, 2024
- Why I did it
Added a script for CMIS Host Management enabling and disabling on a running switch.
This intend to prevent issues caused by wrong configuration of the feature.
The idea is to provide a more convenient way for users to configure the feature.

- How I did it
Add the script to /usr/bin/ that supports two options:
--enable - receives paths to config files for Port SI parameters and Module SI parameters:
media_settings.json, optics_si_settings.json, and enables the feature
--disable - disables the feature
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #19751

@dprital
Copy link
Collaborator

dprital commented Jul 31, 2024

I'm good to cherry-pick to 202405. But we don't need it for 202311 as we don't have CMIS in 202311.

CMIS was added to 202311. having this script will assist with Enable\ Disable of CMIS Host management.
It was already merged to 202311: #19526

@bingwang-ms
Copy link
Contributor

I'm good to cherry-pick to 202405. But we don't need it for 202311 as we don't have CMIS in 202311.

CMIS was added to 202311. having this script will assist with Enable\ Disable of CMIS Host management. It was already merged to 202311: #19526

Yes, you are right.

mssonicbld pushed a commit that referenced this pull request Aug 1, 2024
- Why I did it
Added a script for CMIS Host Management enabling and disabling on a running switch.
This intend to prevent issues caused by wrong configuration of the feature.
The idea is to provide a more convenient way for users to configure the feature.

- How I did it
Add the script to /usr/bin/ that supports two options:
--enable - receives paths to config files for Port SI parameters and Module SI parameters:
media_settings.json, optics_si_settings.json, and enables the feature
--disable - disables the feature
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Aug 1, 2024
- Why I did it
Added a script for CMIS Host Management enabling and disabling on a running switch.
This intend to prevent issues caused by wrong configuration of the feature.
The idea is to provide a more convenient way for users to configure the feature.

- How I did it
Add the script to /usr/bin/ that supports two options:
--enable - receives paths to config files for Port SI parameters and Module SI parameters:
media_settings.json, optics_si_settings.json, and enables the feature
--disable - disables the feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants