[config-bcm] set bcm_tunnel_term_compatible_mode=1 for all platforms #1953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to Broadcom: - This setting doesn't affect currently Broadcom SAI 3.1 behavior. - This setting is required for upcoming SAI version(s). Signed-off-by: Ying Xie <ying.xie@microsoft.com>
stcheng
reviewed
Aug 20, 2018
| @@ -1,5 +1,6 @@ | |||
| #/****************************************************************************** | |||
| # * | |||
| bcm_tunnel_term_compatible_mode=1 | |||
There was a problem hiding this comment.
why this line of the configuration is inserted inside the comment header?
There was a problem hiding this comment.
It was added by a script. I didn't look closely at the end result. I can move it if you prefer.
|
@yxieca , if this has to be enabled for every platform, we should ask broadcom add this into SAI. It is difficult to enforce this for all platform (new ones). |
|
@lguohan I think you got a great point there. Let me talk to Broadcom. |
|
Broadcom will take care of this in SAI. |
liorghub
added a commit
to liorghub/sonic-buildimage
that referenced
this pull request
Mar 23, 2022
Update sonic-swss submodule to include below commits: d80094b [aclorch] Do not fail ACL rule remove flow if rule already deleted (sonic-net#2183) bea0b70 [gcov]: Change coverage.xml file references (sonic-net#2120) 829b219 [tunnelmgrd]: Warm boot support (sonic-net#2166) ad65b0a Fix issue: sometimes PFC WD unable to create zero buffer pool (sonic-net#2164) 608acc3 [doc] Moving Configuration.md from swss to yang sub-folder (sonic-net#2177) 0294376 [orchagent] NVGRE Tunnel orchestration agent implementation (sonic-net#1953) ce88696 [ci] Update default sonic image downloading build ID. (sonic-net#2175)
6 tasks
liat-grozovik
pushed a commit
that referenced
this pull request
Mar 29, 2022
Update sonic-swss submodule to include below commits: d80094b [aclorch] Do not fail ACL rule remove flow if rule already deleted (#2183) bea0b70 [gcov]: Change coverage.xml file references (#2120) 829b219 [tunnelmgrd]: Warm boot support (#2166) ad65b0a Fix issue: sometimes PFC WD unable to create zero buffer pool (#2164) 608acc3 [doc] Moving Configuration.md from swss to yang sub-folder (#2177) 0294376 [orchagent] NVGRE Tunnel orchestration agent implementation (#1953) ce88696 [ci] Update default sonic image downloading build ID. (#2175) Co-authored-by: liora <liora@nvidia.com>
Ndancejic
pushed a commit
to Ndancejic/sonic-buildimage
that referenced
this pull request
May 3, 2022
…t#1953) - What I did Implemented the NVGRE Tunnel orchestration agent according to the - SONiC NVGRE Tunnel HLD - Why I did it Part of the NVGRE feature support. - How I verified it Implemented VS test. Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Broadcom:
Signed-off-by: Ying Xie ying.xie@microsoft.com
- What I did
set bcm_tunnel_term_compatible_mode=1 for all platforms
- How I did it
This change is done by a bash script. The choice of location to insert might not be the best as result.
- How to verify it
I tested this change on a few platforms that I have access to. Did not exhausting all platforms.