-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mellanox] Adding SKU Mellanox-SN5600-C256A1 #19619
Conversation
35b6331
to
68f042d
Compare
i believe there is a general issue with master builds, once it is fixed this need to re run. |
dual-TOR test failed
|
Ethernet501 501 etp63f 63 100000 rs off 6 | ||
Ethernet502 502 etp63g 63 100000 rs off 7 | ||
Ethernet503 503 etp63h 63 100000 rs off 8 | ||
Ethernet512 512 etp65 65 25000 rs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this one contains 1 25G port, do you mind to rename the SKU to C256X1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, but as far as I am aware this should be C256A1 (e.g. Mellanox-SN4700-A96C8V8 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @DavidZagury , not really, the last port is 25Gb, and it should be X not A. @yxieca can correct me, if I am wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@r12f My notes says that the speed / name map is:
10Gb - "S"
25Gb - "A"
50Gb - "D"
100Gb - "C"
200Gb - "V"
400Gb - "O"
And this matches what we see in other SKUs such as SN4700-A96C8V8.
But I don't know where to find an official answer to that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 comment on the SKU naming to make it align with the naming convension.
54a5f9e
Why I did it Support Mellanox-SN5600-C256A1 How I did it Add relevant files to support the new SKU How to verify it Regression test
Cherry-pick PR to 202405: #20307 |
Why I did it Support Mellanox-SN5600-C256A1 How I did it Add relevant files to support the new SKU How to verify it Regression test
Why I did it
Support Mellanox-SN5600-C256A1
Work item tracking
How I did it
Add relevant files to support the new SKU
How to verify it
Regression test
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)