[dhcp_server] Remove invoke of dhcpmon when dhcp_server is enabled #19673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaqiangz
commented
Jul 24, 2024
This reverts commit 985273e.
Blueve
approved these changes
Jul 25, 2024
|
Hi @yxieca could you please help to merge this PR and approve the backup request? |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jul 25, 2024
…onic-net#19673) * [dhcp_server] Remove invoke of dhcpmon when dhcp_server is enabled * set include_dhcp_server to y * Update log * Revert "set include_dhcp_server to y" This reverts commit 985273e.
|
Cherry-pick PR to 202405: #19683 |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jul 25, 2024
…onic-net#19673) * [dhcp_server] Remove invoke of dhcpmon when dhcp_server is enabled * set include_dhcp_server to y * Update log * Revert "set include_dhcp_server to y" This reverts commit 985273e.
|
Cherry-pick PR to 202311: #19684 |
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
liushilongbuaa
pushed a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Aug 1, 2024
…onic-net#19673) * [dhcp_server] Remove invoke of dhcpmon when dhcp_server is enabled * set include_dhcp_server to y * Update log * Revert "set include_dhcp_server to y" This reverts commit 985273e.
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
dhcpmon is not ready to count packets for dhcp_server, hence remove invoking of it for now
Work item tracking
How I did it
Remove starting dhcpmon when dhcp_server is enabled
How to verify it
UT passed
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)