Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[platform]: update mitac platform drivers and device #2024

Closed
wants to merge 8 commits into from
Closed

[platform]: update mitac platform drivers and device #2024

wants to merge 8 commits into from

Conversation

stanepc1
Copy link
Contributor

@stanepc1 stanepc1 commented Sep 6, 2018

- What I did
Update ly1200 to support stretch
- How I did it
Modify driver code
- How to verify it
Upload image to DUT to ensure all modules are running correctly.
- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Stane Shieh <stane.shieh@mic.com.tw>
Signed-off-by: Stane Shieh <stane.shieh@mic.com.tw>
… of i2c modules.

Signed-off-by: Stane Shieh <stane.shieh@mic.com.tw>
Signed-off-by: Stane Shieh <stane.shieh@mic.com.tw>
* RETURNS:
* No.
*/
void* bms_xcvr_polld(void *args)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is essentially the xrcvd does.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If our xcvr-servd is not running in SONiC, we will not see "state UP" via the "ip addr" command and will not see anything through the "show interfaces transceiver eeprom" command when plugging in the transceiver.

The implementation difference between our xcvr-servd and SONiC's xrcvd might be related to our hardware design. Please allow our xcvr-servd to run on SONiC for our platform module.

@lguohan
Copy link
Collaborator

lguohan commented Sep 6, 2018

we need license for all source code file, for user space file, please use apache license.

Signed-off-by: Stane Shieh <stane.shieh@mic.com.tw>
* for other cases, negative errno is returned.
*/
static int
bms_xcvr_i2c_write(unsigned char bus,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have sff_8436_eeprom driver allow you user to access sfp eeprom data via sysfs. It is redudant to have same code in user space that does the same thing.

@@ -0,0 +1,345 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the function here is overalpping with the sff_8436_eeprom driver in sonic.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two main benefits to access EEPROM via the API of bms_xcvr_access.c

  1. it is a portable implementation that does not depend on any EEPROM driver.
  2. the execution performance is faster than calling three APIs open(), read()/write(), and close() to access sysfs.

@lguohan
Copy link
Collaborator

lguohan commented Sep 22, 2018

minigraph.xml is no longer needed.

@stanepc1
Copy link
Contributor Author

remove minigraph.xml

@stanepc1
Copy link
Contributor Author

According to the console output at https://sonic-jenkins.westus2.cloudapp.azure.com/job/broadcom/job/buildimage-brcm-all-pr/2928/, the failure was caused by "port 443: the network is unreachable".

Can you help us solve the problem "port 443: the network is unreachable" by your side?

@stanepc1
Copy link
Contributor Author

stanepc1 commented Oct 2, 2018

We will modify the default level of low-speed pins for plug&play of QSFP and remove the controversial "xcvr_servd" of MiTAC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants