Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back publish events to memory_checker #20306

Merged

Conversation

zbud-msft
Copy link
Contributor

Why I did it

#19179 removed call to publish_events when memory usage container exceeds threshold, causing test_events to fail.

Work item tracking
  • Microsoft ADO (number only): 28728116

How I did it

Add back call to publish_events

How to verify it

Manual test

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@qiluo-msft qiluo-msft merged commit 265a79f into sonic-net:master Sep 23, 2024
23 checks passed
@bingwang-ms
Copy link
Contributor

Removing the request for 202405 branch as per offline discussion.

saksarav-nokia pushed a commit to saksarav-nokia/sonic-buildimage that referenced this pull request Oct 9, 2024
### Why I did it

sonic-net#19179 removed call to publish_events when memory usage container exceeds threshold, causing test_events to fail.

### How I did it

Add back call to publish_events

#### How to verify it

Manual test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants