[docker-fpm-frr] Set default value to SMARTSWITCH env variable in TSA/B/C #20413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sourcing the platform_utils file. Signed-off-by: fountzou <ioannis.fountzoulas@nokia.com>
fountzou
changed the title
|
/azpw ms_conflict |
arlakshm
approved these changes
Oct 23, 2024
|
Hi @abdosi, Could you please help to review? This affects Reliable TSA testcases sonic-net/sonic-mgmt#13290 which are about to be merged. |
|
@kperumalbfn, please help signoff and merge |
kperumalbfn
approved these changes
Oct 23, 2024
rkavitha-hcl
pushed a commit
to rkavitha-hcl/sonic-buildimage
that referenced
this pull request
Nov 15, 2024
… sourcing the platform_utils file. (sonic-net#20413) Set the default value of `SMARTSWITCH` to false and error handling in sourcing the platform_utils file. Signed-off-by: fountzou <ioannis.fountzoulas@nokia.com>
aidan-gallagher
pushed a commit
to aidan-gallagher/sonic-buildimage
that referenced
this pull request
Nov 16, 2024
… sourcing the platform_utils file. (sonic-net#20413) Set the default value of `SMARTSWITCH` to false and error handling in sourcing the platform_utils file. Signed-off-by: fountzou <ioannis.fountzoulas@nokia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Recently, as part of #19729, TSA/B/C functionality has been modified to take into account the env variable
SMARTSWITCH. This env variable is being exposed though a newly addedplatform_utilsfile in frr.The expected behavior is that
platform_utilsscript to be present; instead it is missing.SMARTSWITCHvalue to be eithertrueorfalse; instead it is" ".As a result, "reliable TSA" feature is affected. This PR fixes this issue.
Work item tracking
How I did it
platform_utilsscript have been suppressed.SMARTSWITCHdefault value is set tofalseif it has been unset or empty.How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)