-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install rdb-cli on syncd-dnx #20948
Merged
lguohan
merged 1 commit into
sonic-net:master
from
patrickmacarthur:master-install-rdb-cli-on-syncd-dnx
Dec 4, 2024
Merged
Install rdb-cli on syncd-dnx #20948
lguohan
merged 1 commit into
sonic-net:master
from
patrickmacarthur:master-install-rdb-cli-on-syncd-dnx
Dec 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was missed on the original PR and caused show_techsupport sonic-mgmt tests to fail.
/azpw ms_conflict |
judyjoseph
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Dec 4, 2024
This was missed on the original PR and caused show_techsupport sonic-mgmt tests to fail. Why I did it PR sonic-net#19268 replaced redis-rdb-tool with rdb-cli in the Broadcom XGS syncd container. However, it did not do the same for the DNX syncd container, leading to sonic-mgmt failures in show_techsupport tests on DNX platforms. How I did it I applied the same change to the Broadcom DNX syncd container. How to verify it Run sonic-mgmt show_techsupport tests on a Broadcom DNX DUT.
Cherry-pick PR to 202405: #21033 |
mssonicbld
pushed a commit
that referenced
this pull request
Dec 5, 2024
This was missed on the original PR and caused show_techsupport sonic-mgmt tests to fail. Why I did it PR #19268 replaced redis-rdb-tool with rdb-cli in the Broadcom XGS syncd container. However, it did not do the same for the DNX syncd container, leading to sonic-mgmt failures in show_techsupport tests on DNX platforms. How I did it I applied the same change to the Broadcom DNX syncd container. How to verify it Run sonic-mgmt show_techsupport tests on a Broadcom DNX DUT.
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missed on the original PR and caused show_techsupport sonic-mgmt tests to fail.
Why I did it
PR #19268 replaced redis-rdb-tool with rdb-cli in the Broadcom XGS syncd container. However, it did not do the same for the DNX syncd container, leading to sonic-mgmt failures in show_techsupport tests on DNX platforms.
Work item tracking
How I did it
I applied the same change to the Broadcom DNX syncd container.
How to verify it
Run sonic-mgmt show_techsupport tests on a Broadcom DNX DUT.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)