Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update internal template peer-group.conf.j2 for ttl-security hops command. #21117

Merged
merged 6 commits into from
Dec 11, 2024

Conversation

abdosi
Copy link
Contributor

@abdosi abdosi commented Dec 10, 2024

What I did:
Fixes: #21116

Why I did:
FRR behavior change w.r.t to command ttl-security hops <> from being removed from address-family .

@abdosi abdosi requested a review from lguohan as a code owner December 10, 2024 13:03
@abdosi abdosi requested a review from StormLiangMS as a code owner December 10, 2024 13:05
@abdosi
Copy link
Contributor Author

abdosi commented Dec 10, 2024

@cyw233 @anamehra @yejianquan for viz.

@abdosi abdosi changed the title Update peer-group.conf.j2 Update internal template peer-group.conf.j2 for ttl-security hops command. Dec 10, 2024
@abdosi abdosi requested a review from arlakshm December 11, 2024 02:25
@abdosi
Copy link
Contributor Author

abdosi commented Dec 11, 2024

Hi @arlakshm , can you help with review of this.

@abdosi
Copy link
Contributor Author

abdosi commented Dec 11, 2024

@rlhui : can you help with merge of this.

Copy link
Contributor

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit 7bdf8d4 into master Dec 11, 2024
23 checks passed
@StormLiangMS
Copy link
Contributor

hi @abdosi could we have an internal ADO for tracking?
@bingwang-ms this is only for T2, internal peer, should be fine to take into 202405.

@abdosi
Copy link
Contributor Author

abdosi commented Dec 11, 2024

@yejianquan : can you update ADO details in PR description.

@yejianquan
Copy link
Contributor

Not able to update PR description:

@StormLiangMS @abdosi
That's the internal ADO:
#30112527

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Dec 11, 2024
…mand. (sonic-net#21117)

What I did:
Fixes: sonic-net#21116

Why I did:
FRR behavior change w.r.t to command ttl-security hops <> from being removed from address-family .
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #21129

@rlhui
Copy link
Contributor

rlhui commented Dec 11, 2024

@abdosi is it needed for 202411 too?

@abdosi abdosi deleted the abdosi-patch-1 branch December 11, 2024 10:26
mssonicbld pushed a commit that referenced this pull request Dec 11, 2024
…mand. (#21117)

What I did:
Fixes: #21116

Why I did:
FRR behavior change w.r.t to command ttl-security hops <> from being removed from address-family .
VladimirKuk pushed a commit to Marvell-switching/sonic-buildimage that referenced this pull request Jan 21, 2025
…mand. (sonic-net#21117)

What I did:
Fixes: sonic-net#21116

Why I did:
FRR behavior change w.r.t to command ttl-security hops <> from being removed from address-family .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Status: Done
Development

Successfully merging this pull request may close these issues.

seeing error in chassis bgp on restarting bgp
7 participants