Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Zebra fpm backpressure patches to dplane_fpm_sonic #21146

Merged

Conversation

cscarpitta
Copy link
Contributor

Why I did it

Reduce high CPU usage on zebra after performing port toggle on all interfaces simultaneously

How I did it

Apply zebra fpm backpressure patches from FRR mainline to dplane_fpm_sonic:

Apply the following patch to dplane_fpm_sonic:
* zebra: Use built in data structure counter (FRRouting/frr#16221)

Signed-off-by: cscarpitta <cscarpit@cisco.com>
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cscarpitta cscarpitta changed the title Fix/dplane fpm sonic backpressure Apply Zebra fpm backpressure patches to dplane_fpm_sonic Dec 12, 2024
@cscarpitta
Copy link
Contributor Author

Fixes #21008

Apply the following patch to dplane_fpm_sonic:
* Zebra fpm backpressure (FRRouting/frr#16220)

Signed-off-by: cscarpitta <cscarpit@cisco.com>
Signed-off-by: cscarpitta <cscarpit@cisco.com>
@cscarpitta cscarpitta force-pushed the fix/dplane-fpm-sonic-backpressure branch from 60e0f12 to 6bff249 Compare December 12, 2024 12:41
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@saksarav-nokia
Copy link
Contributor

@cscarpitta , does this address the high memory usage as well?

@cscarpitta cscarpitta marked this pull request as ready for review December 13, 2024 08:52
@cscarpitta cscarpitta requested a review from lguohan as a code owner December 13, 2024 08:52
@cscarpitta
Copy link
Contributor Author

@cscarpitta , does this address the high memory usage as well?

@saksarav-nokia Yes, this PR also fixes the high memory usage

@ahsalam
Copy link

ahsalam commented Dec 13, 2024

@kperumalbfn this PR fixes the issue.

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202411: #21356

VladimirKuk pushed a commit to Marvell-switching/sonic-buildimage that referenced this pull request Jan 21, 2025
…sonic-net#21146)

Why I did it
Reduce high CPU usage on zebra after performing port toggle on all interfaces simultaneously

How I did it
Apply zebra fpm backpressure patches from FRR mainline to dplane_fpm_sonic:

zebra: Use built in data structure counter (zebra: Use built in data structure counter FRRouting/frr#16221)
Zebra fpm backpressure (Zebra fpm backpressure FRRouting/frr#16220)

Signed-off-by: cscarpitta <cscarpit@cisco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants