Adding YANG model for TC_TO_DSCP_MAP #21395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@wen587 Kindly help review this PR, thx ! |
|
@wen587 Can you please help review? |
wen587
reviewed
Jan 15, 2025
| @@ -18,7 +18,8 @@ | |||
| 'DSCP_TO_FC_MAP_LIST', | |||
| 'EXP_TO_FC_MAP_LIST', | |||
| 'CABLE_LENGTH_LIST', | |||
| 'MPLS_TC_TO_TC_MAP_LIST' | |||
| 'MPLS_TC_TO_TC_MAP_LIST', | |||
| 'TC_TO_DSCP_MAP_LIST' | |||
There was a problem hiding this comment.
Please also add this MAP to here for sonic yang support:
sonic-buildimage/src/sonic-yang-mgmt/sonic_yang_ext.py
Lines 11 to 23 in c0319e0
There was a problem hiding this comment.
Hi @raaghavendrakra-arista , please add new table here for sonic yang support. Others look good to me.
There was a problem hiding this comment.
Hi @wen587, I didn't get you, I see that I have already added the new MAP to the table you are pointing (line 22)
correct me if I'm wrong.
ganglyu
reviewed
Jan 15, 2025
|
@raaghavendrakra-arista Can you confirm if this change is required for 202405? I don't think we have the yang validator in 202405 branch. |
True, not required for 202405, this is specific to 202411 as the config_validator.py file is introduced from 202411 onwards. |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wen587
approved these changes
Jan 16, 2025
ganglyu
approved these changes
Jan 16, 2025
qiluo-msft
approved these changes
Jan 16, 2025
10 tasks
|
Cherry-pick PR to 202411: #21463 |
|
@raaghavendrakra-arista cherry pick PR didn't pass PR checker. Please check!!! |
VladimirKuk
pushed a commit
to Marvell-switching/sonic-buildimage
that referenced
this pull request
Jan 21, 2025
Fixed issue : sonic-net#20575 Why I did it "config-reload" in dualtor topologies were failing due to absence of TC_TO_DSCP Yang model. The above failure was seen after the the PR sonic-net/sonic-utilities#3102 How to verify it Step-1: In DUT add the yang file to "/usr/local/yang-models/sonic-tc-dscp-map.yang" to this path. Step-2: config reload -y Tested branch (Please provide the tested image version) 202411 Description for the changelog Adding YANG model for TC_TO_DSCP_MAP along with test files.
|
@raaghavendrakra-arista cherry pick PR didn't pass PR checker. Please check!!! |
|
@raaghavendrakra-arista cherry pick PR didn't pass PR checker. Please check!!! |
11 tasks
mssonicbld
added a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Feb 10, 2025
<!--
Please make sure you've read and understood our contributing guidelines:
https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md
** Make sure all your commits include a signature generated with `git commit -s` **
If this is a bug fix, make sure your description includes "fixes #xxxx", or
"closes #xxxx" or "resolves #xxxx"
Please provide the following information:
-->
#### Why I did it
Add missing field introduced from PR: sonic-net#21395
##### Work item tracking
- Microsoft ADO **(number only)**: 31313829
#### How I did it
Add the missing field
#### How to verify it
UT in sample_config_db.json
Also test in specific DUT after merge this change.
before:
```
sonic_yang(3):All Keys are not parsed in PORT_QOS_MAP
dict_keys(['Ethernet16'])
sonic_yang(3):exceptionList:["'tc_to_dscp_map'"]
```
after:
```
sonic_yang(6):Note: Below table(s) have no YANG models: bgpraw
```
<!--
If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012.
-->
#### Which release branch to backport (provide reason below if selected)
<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->
- [ ] 201811
- [ ] 201911
- [ ] 202006
- [ ] 202012
- [ ] 202106
- [ ] 202111
- [ ] 202205
- [ ] 202211
- [ ] 202305
#### Tested branch (Please provide the tested image version)
<!--
- Please provide tested image version
- e.g.
- [x] 20201231.100
-->
- [ ] <!-- image version 1 -->
- [ ] <!-- image version 2 -->
#### Description for the changelog
<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog:
-->
<!--
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
-->
#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
-->
#### A picture of a cute animal (not mandatory but encouraged)
11 tasks
mssonicbld
added a commit
that referenced
this pull request
Feb 11, 2025
<!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md failure_prs.log skip_prs.log Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx" or "resolves #xxxx" Please provide the following information: --> #### Why I did it Add missing field introduced from PR: #21395 ##### Work item tracking - Microsoft ADO **(number only)**: 31313829 #### How I did it Add the missing field #### How to verify it UT in sample_config_db.json Also test in specific DUT after merge this change. before: ``` sonic_yang(3):All Keys are not parsed in PORT_QOS_MAP dict_keys(['Ethernet16']) sonic_yang(3):exceptionList:["'tc_to_dscp_map'"] ``` after: ``` sonic_yang(6):Note: Below table(s) have no YANG models: bgpraw ``` <!-- If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012. --> #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 - [ ] 202111 - [ ] 202205 - [ ] 202211 - [ ] 202305 #### Tested branch (Please provide the tested image version) <!-- - Please provide tested image version - e.g. - [x] 20201231.100 --> - [ ] <!-- image version 1 --> - [ ] <!-- image version 2 --> #### Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: --> <!-- Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU. --> #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md --> #### A picture of a cute animal (not mandatory but encouraged)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue : #20575
Why I did it
"config-reload" in dualtor topologies were failing due to absence of TC_TO_DSCP Yang model.
The above failure was seen after the the PR sonic-net/sonic-utilities#3102
Work item tracking
How I did it
How to verify it
Step-1: In DUT add the yang file to "/usr/local/yang-models/sonic-tc-dscp-map.yang" to this path.
Step-2: config reload -y
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Adding YANG model for TC_TO_DSCP_MAP along with test files.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)