Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yang][dhcp_server] Make gateway in dhcp_server to be an un-mandatory config #21475

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

yaqiangz
Copy link
Contributor

@yaqiangz yaqiangz commented Jan 20, 2025

Why I did it

DHCP default route shoule be an optional config to DHCP client

Work item tracking
  • Microsoft ADO (number only): 30877295

How I did it

Make the configuration to be optional in yang model

How to verify it

UTs

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yaqiangz yaqiangz changed the title [yang][dhcp_server] gateway in dhcp_server to be a un-mandatory config [yang][dhcp_server] Make gateway in dhcp_server to be an un-mandatory config Jan 20, 2025
@yaqiangz yaqiangz force-pushed the master_dhcp_server_gateway_yang branch from 15b97a6 to 417cd22 Compare January 20, 2025 07:41
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yaqiangz yaqiangz force-pushed the master_dhcp_server_gateway_yang branch from 417cd22 to dfd6209 Compare January 20, 2025 09:51
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yaqiangz yaqiangz force-pushed the master_dhcp_server_gateway_yang branch from dfd6209 to c684cfa Compare January 21, 2025 02:46
@yaqiangz yaqiangz closed this Jan 21, 2025
@yaqiangz yaqiangz reopened this Jan 21, 2025
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yaqiangz yaqiangz marked this pull request as ready for review January 23, 2025 02:04
@yaqiangz yaqiangz requested a review from qiluo-msft as a code owner January 23, 2025 02:04
@yaqiangz yaqiangz requested a review from Blueve January 26, 2025 04:59
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yxieca yxieca merged commit 6415e4d into sonic-net:master Jan 27, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants