[sonic-py-common] Strip the MAC before returning from get_system_mac() #21591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a corner case where the MAC address includes a trailing "\n" character, leading to switch configuration failure. To prevent this issue, the final return statement now explicitly strips the MAC in all cases. This commit implements that fix. Signed-off-by: Vasundhara Volam <vvolam@microsoft.com>
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
saiarcot895
approved these changes
Feb 1, 2025
prgeor
approved these changes
Feb 1, 2025
Merged
14 tasks
|
Cherry-pick PR to 202405: #21602 |
Merged
14 tasks
|
Cherry-pick PR to 202411: #21604 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
There is a corner case where the MAC address includes a trailing "\n" character in the config_db.json file, leading to switch configuration failure.
Work item tracking
How I did it
To prevent this issue, the final return statement now explicitly strips the MAC in all cases from get_system_mac().
How to verify it
Load the new image to verify the mac does not contain any trailing unnecessary characters in the config_db.json file/
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)