-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Yang] Add Yang Model and tests for VNET_ROUTE_TUNNEL table - v2 #21939
base: master
Are you sure you want to change the base?
Conversation
…st cases (2) Fix sample data name constraints
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
d85d0a9
to
f7e11e2
Compare
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
04cc907
to
c1535ee
Compare
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
03/06: Merged the latest changes from master to rerun the auto-cancelled pipeline. |
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
03/07 a0be257 passed all pipeline checks. |
type yang:mac-address; | ||
} | ||
|
||
leaf vxlanid { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you change this to vni. Upon checking sonic-swss I see that this should be called vni:
https://github.com/sonic-net/sonic-swss/blob/master/orchagent/vnetorch.cpp#L2733
@prsunny should we update the HLD https://github.com/sonic-net/SONiC/blob/gh-pages/doc/vxlan/Vxlan_hld.md to say that the tunnel route field is vni vs vxlandid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The vni in VNET_ROUTE_TUNNEL_TABLE overrides the base vni in VNET_TABLE for any traffic destined to the IP of prefix in VNET_ROUTE_TUNNEL_TABLE. It is also an optional field, so if none is provided the default VNET_TABLE vni is used for the traffic.
Why I did it
Added YANG model and tests for VNET_ROUTE_TUNNEL table to provide schema validation and testing capabilities for VNET route tunnel configurations.
Work item tracking
How I did it
How to verify it
Test Cases Validated
Yang Model Validated (assertionError can be ignored)
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md/VNET_ROUTE_TUNNEL