remove tty in docker run #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
Jan 31, 2017
Makefile
Outdated
| @@ -11,7 +11,7 @@ MAKEFLAGS += -B | |||
|
|
|||
| DOCKER_RUN := docker run --rm=true --privileged \ | |||
| -v $(PWD):/sonic \ | |||
| -it sonic-slave-$(USER) | |||
| sonic-slave-$(USER) | |||
There was a problem hiding this comment.
Maybe not necessary in this case, I think we can keep '-i'. It is possible that some internal binary will detect environment and run conditional code.
There was a problem hiding this comment.
Agree with @qiluo-msft
I'd add something like -i$(SONIC_SLAVE_TTY)
There was a problem hiding this comment.
what is SONIC_SLAVE_TTY?
There was a problem hiding this comment.
@marian-pritsak What is 'SONIC_SLAVE_TTY'? If not used, we can remove it.
marian-pritsak
approved these changes
Jan 31, 2017
Kalimuthu-Velappan
pushed a commit
to Kalimuthu-Velappan/sonic-buildimage
that referenced
this pull request
Sep 12, 2019
…onic-net#225) * Check user id for fast-reboot-dump.py script * exit with exit code 1 * Use TCP to connect to the DB. Remove check for super user as redundant * Finnaly Remove check for super user as redundant
madhanmellanox
pushed a commit
to madhanmellanox/sonic-buildimage
that referenced
this pull request
Mar 23, 2020
- Add -d record_location option to indicate the folder for putting SAI Redis recording file and SwSS recording file. - The size of this folder should be monitored and limited to prevent disk space full issue.
dmytroxshevchuk
pushed a commit
to dmytroxshevchuk/sonic-buildimage
that referenced
this pull request
Aug 31, 2020
5 tasks
lguohan
pushed a commit
that referenced
this pull request
Nov 16, 2021
c8eceec 400zr initial support (#228) ef55364 SSD Health: Retrieve SSD health and temperature values from generic SSD info (#229) 26c8346 Fix cmis cable length issue (#225) 671927d Fix typo in the simulated y_cable driver (#226) 51a9aca [sfp-refactor] Add initial support for CMIS in sonic_xcvr (#220) Signed-off-by: Prince George <prgeor@microsoft.com>
5 tasks
sg893052
pushed a commit
to sg893052/sonic-buildimage
that referenced
this pull request
Apr 25, 2022
Adding test plan for PoE
6 tasks
mihirpat1
pushed a commit
to mihirpat1/sonic-buildimage
that referenced
this pull request
Feb 21, 2023
Description Enable 50% Diff Coverage for sonic-platform-daemons PR build Motivation and Context Enhance the code quality
snider-nokia
pushed a commit
to snider-nokia/sonic-buildimage
that referenced
this pull request
Apr 6, 2023
mssonicbld
added a commit
that referenced
this pull request
Dec 14, 2023
#17476) #### Why I did it src/linkmgrd ``` * 79c3872 - (HEAD -> master, origin/master, origin/HEAD) [active-standby] Fix `show mux status` inconsistency introduced by orchagent rollback (#225) (24 hours ago) [Jing Zhang] * ba913c0 - [warmboot] use config_db connector to update mux mode config instead of CLI (#223) (2 days ago) [Jing Zhang] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.