[swss service] don't clear WARM_RESTART table #2256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clear WARM_RESTART table could cause component level warm restart to fail due to missing WARM_RESTART state. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
|
we need to only clear the restart count for teammgrd. the other restore_count in swss container should be cleared. |
|
Syncd is also in the same camp as teammgrd. Keep all states is safe, they will be reset back to 0 by WarmRestart class in each module. |
|
thanks for fixing this |
yxieca
added a commit
to yxieca/sonic-buildimage
that referenced
this pull request
Oct 26, 2022
… submodule head utilities: * 02eb899e 2022-07-12 | [config/load_mgmt_config] Support load IPv6 mgmt IP (sonic-net#2206) (sonic-net#2246) (sonic-net#2256) (HEAD -> 201811, github/201811) [Jing Kan] platform-daemon: * fc288cc 2022-05-05 | Mem leak caused by Xcvrd in Send-Q of REDIS-DB socket connection (sonic-net#260) (HEAD -> 201811, github/201811) [Prince George] platform-common: * edb062b 2022-02-09 | [sonic_sfp] Interpret sff 'int' element =0 as valid value (sonic-net#261) (HEAD -> 201811, github/201811) [Prince George] kernel: * 9d2d1a1 2022-02-11 | [201811] Increase log_buf_len size to 1M (HEAD -> 201811, github/201811) [Sujin Kang] * b34a213 2022-02-10 | [201811] Increase log_buf_len size to 1M [Samuel Angebault] * c4684cb 2022-02-11 | [201811] Apply kernel patches to fix emmc unreliability [Sujin Kang] * df68771 2022-02-03 | [201811] Apply kernel patches to fix emmc unreliability [Samuel Angebault] * f21cb06 2021-03-26 | [ci]: remove 201811 suffix (sonic-net#204) [lguohan] * 5439b2a 2021-02-08 | [dni_dps460] Add attributes to retrieve PMBus status command codes (sonic-net#194) [Arun Saravanan Balachandran] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
yxieca
added a commit
that referenced
this pull request
Oct 26, 2022
… submodule head (#12494) utilities: * 02eb899e 2022-07-12 | [config/load_mgmt_config] Support load IPv6 mgmt IP (#2206) (#2246) (#2256) (HEAD -> 201811, github/201811) [Jing Kan] platform-daemon: * fc288cc 2022-05-05 | Mem leak caused by Xcvrd in Send-Q of REDIS-DB socket connection (#260) (HEAD -> 201811, github/201811) [Prince George] platform-common: * edb062b 2022-02-09 | [sonic_sfp] Interpret sff 'int' element =0 as valid value (#261) (HEAD -> 201811, github/201811) [Prince George] kernel: * 9d2d1a1 2022-02-11 | [201811] Increase log_buf_len size to 1M (HEAD -> 201811, github/201811) [Sujin Kang] * b34a213 2022-02-10 | [201811] Increase log_buf_len size to 1M [Samuel Angebault] * c4684cb 2022-02-11 | [201811] Apply kernel patches to fix emmc unreliability [Sujin Kang] * df68771 2022-02-03 | [201811] Apply kernel patches to fix emmc unreliability [Samuel Angebault] * f21cb06 2021-03-26 | [ci]: remove 201811 suffix (#204) [lguohan] * 5439b2a 2021-02-08 | [dni_dps460] Add attributes to retrieve PMBus status command codes (#194) [Arun Saravanan Balachandran] Signed-off-by: Ying Xie <ying.xie@microsoft.com> Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ying Xie ying.xie@microsoft.com
- What I did
Clear WARM_RESTART table could cause component level warm restart to
fail due to missing WARM_RESTART state.
- How to verify it
Cold boot up a system with the change. Check output of "show warm_restart state" output, making sure that teammgrd's state and syncd's state are there.