-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[update graph] adapt to warm reboot scenario #2353
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When migrating configuration, always copy config files from old_config to /etc/sonic. But if warm reboot is detected, then skip configuration operations. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
taoyl-ms
reviewed
Dec 6, 2018
taoyl-ms
approved these changes
Dec 6, 2018
zhenggen-xu
reviewed
Dec 6, 2018
lguohan
approved these changes
Dec 6, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zhenggen-xu
approved these changes
Dec 6, 2018
vivekrnv
added a commit
to vivekrnv/sonic-buildimage
that referenced
this pull request
Jun 24, 2022
93af69c [PFC_WD] Avoid applying ZeroBuffer Profiles to ingress PG when a PFC storm is detected (sonic-net#2304) 37349cf [swssconfig] Optimize performance of swssconfig (sonic-net#2336) 84e9b07 [fdborch] fix heap-use-after-free in clearFdbEntry() (sonic-net#2353) 1b8bd94 Create ACL table fails due to incorrect check for supported ACL actions sonic-net#11235 (sonic-net#2351) 1ed0b4b [macsec] Refactor the logic of macsec name map (sonic-net#2348) f88f992 [mock_tests] Add Sflow Orch UTs (sonic-net#2295) ec57bf1 [macsec] Update macsec flex counter (sonic-net#2338) 6e0fc85 [ACL] Support stage particular match fields (sonic-net#2341) efb4530 [orchagent, DTel]: report session support to set user vrf (sonic-net#2326) d82874d Fix for "orchagent crashed when trying to delete fdb static entry with swssconfig sonic-net#11046" (sonic-net#2332) 0c789e6 Fix qos map test in vs test (sonic-net#2343) 1bb5070 Enhance mock test for dynamic buffer manager for port removing and qos reload flows (sonic-net#2262) 700492f [aclorch] Fix and simplify DTel watchlist tables and entries (sonic-net#2155) Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
yxieca
added a commit
to yxieca/sonic-buildimage
that referenced
this pull request
Jun 25, 2022
swss: * ad2d0ad 2022-06-24 | [PFC_WD] Avoid applying ZeroBuffer Profiles to ingress PG when a PFC storm is detected (sonic-net#2304) (HEAD -> 202205) [Vivek R] * ef75554 2022-06-25 | [swssconfig] Optimize performance of swssconfig (sonic-net#2336) [Junchao-Mellanox] * d9e9ba8 2022-06-24 | [fdborch] fix heap-use-after-free in clearFdbEntry() (sonic-net#2353) [Yakiv Huryk] * 585a69b 2022-06-24 | Create ACL table fails due to incorrect check for supported ACL actions sonic-net#11235 (sonic-net#2351) [Ravindranath C K] * 0d19560 2022-06-24 | [macsec] Refactor the logic of macsec name map (sonic-net#2348) [Junhua Zhai] * 111dfc2 2022-06-23 | [macsec] Update macsec flex counter (sonic-net#2338) (HEAD -> 202205, github/202205) [Junhua Zhai] swss-common: * 0213d55 2022-06-23 | [portcounter] Check if counter ID exists before arithmetic operation (sonic-net#632) (HEAD -> 202205, github/202205) [Junhua Zhai] * c21c47e 2022-06-14 | [counter] Add counter table (sonic-net#622) [Junhua Zhai] utilities: * 430cd65 2022-06-23 | [202205] [generate dump] Move the Core/Log collection to the End of process Execution and removed default timeout (sonic-net#2230) (github/202205) [Vivek R] linkmgrd: * 59334be 2022-06-24 | Remove exception throwing when initializing missing loopback interface (sonic-net#90) (HEAD -> 202205) [Jing Zhang] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
yxieca
added a commit
that referenced
this pull request
Jun 27, 2022
swss: * ad2d0ad 2022-06-24 | [PFC_WD] Avoid applying ZeroBuffer Profiles to ingress PG when a PFC storm is detected (#2304) (HEAD -> 202205) [Vivek R] * ef75554 2022-06-25 | [swssconfig] Optimize performance of swssconfig (#2336) [Junchao-Mellanox] * d9e9ba8 2022-06-24 | [fdborch] fix heap-use-after-free in clearFdbEntry() (#2353) [Yakiv Huryk] * 585a69b 2022-06-24 | Create ACL table fails due to incorrect check for supported ACL actions #11235 (#2351) [Ravindranath C K] * 0d19560 2022-06-24 | [macsec] Refactor the logic of macsec name map (#2348) [Junhua Zhai] * 111dfc2 2022-06-23 | [macsec] Update macsec flex counter (#2338) (HEAD -> 202205, github/202205) [Junhua Zhai] swss-common: * 0213d55 2022-06-23 | [portcounter] Check if counter ID exists before arithmetic operation (#632) (HEAD -> 202205, github/202205) [Junhua Zhai] * c21c47e 2022-06-14 | [counter] Add counter table (#622) [Junhua Zhai] utilities: * 430cd65 2022-06-23 | [202205] [generate dump] Move the Core/Log collection to the End of process Execution and removed default timeout (#2230) (github/202205) [Vivek R] linkmgrd: * 59334be 2022-06-24 | Remove exception throwing when initializing missing loopback interface (#90) (HEAD -> 202205) [Jing Zhang] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
prsunny
pushed a commit
that referenced
this pull request
Jun 28, 2022
Swss commits: 93af69c [PFC_WD] Avoid applying ZeroBuffer Profiles to ingress PG when a PFC storm is detected (#2304) 37349cf [swssconfig] Optimize performance of swssconfig (#2336) 84e9b07 [fdborch] fix heap-use-after-free in clearFdbEntry() (#2353) 1b8bd94 Create ACL table fails due to incorrect check for supported ACL actions #11235 (#2351) 1ed0b4b [macsec] Refactor the logic of macsec name map (#2348) f88f992 [mock_tests] Add Sflow Orch UTs (#2295) ec57bf1 [macsec] Update macsec flex counter (#2338) 6e0fc85 [ACL] Support stage particular match fields (#2341) efb4530 [orchagent, DTel]: report session support to set user vrf (#2326) d82874d Fix for "orchagent crashed when trying to delete fdb static entry with swssconfig #11046" (#2332) 0c789e6 Fix qos map test in vs test (#2343) 1bb5070 Enhance mock test for dynamic buffer manager for port removing and qos reload flows (#2262) 700492f [aclorch] Fix and simplify DTel watchlist tables and entries (#2155) Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
robertvolkmann
pushed a commit
to robertvolkmann/sonic-buildimage
that referenced
this pull request
Jul 26, 2022
…et#11254) swss: * ad2d0ad 2022-06-24 | [PFC_WD] Avoid applying ZeroBuffer Profiles to ingress PG when a PFC storm is detected (sonic-net#2304) (HEAD -> 202205) [Vivek R] * ef75554 2022-06-25 | [swssconfig] Optimize performance of swssconfig (sonic-net#2336) [Junchao-Mellanox] * d9e9ba8 2022-06-24 | [fdborch] fix heap-use-after-free in clearFdbEntry() (sonic-net#2353) [Yakiv Huryk] * 585a69b 2022-06-24 | Create ACL table fails due to incorrect check for supported ACL actions sonic-net#11235 (sonic-net#2351) [Ravindranath C K] * 0d19560 2022-06-24 | [macsec] Refactor the logic of macsec name map (sonic-net#2348) [Junhua Zhai] * 111dfc2 2022-06-23 | [macsec] Update macsec flex counter (sonic-net#2338) (HEAD -> 202205, github/202205) [Junhua Zhai] swss-common: * 0213d55 2022-06-23 | [portcounter] Check if counter ID exists before arithmetic operation (sonic-net#632) (HEAD -> 202205, github/202205) [Junhua Zhai] * c21c47e 2022-06-14 | [counter] Add counter table (sonic-net#622) [Junhua Zhai] utilities: * 430cd65 2022-06-23 | [202205] [generate dump] Move the Core/Log collection to the End of process Execution and removed default timeout (sonic-net#2230) (github/202205) [Vivek R] linkmgrd: * 59334be 2022-06-24 | Remove exception throwing when initializing missing loopback interface (sonic-net#90) (HEAD -> 202205) [Jing Zhang] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
skbarista
pushed a commit
to skbarista/sonic-buildimage
that referenced
this pull request
Aug 17, 2022
…et#11254) swss: * ad2d0ad 2022-06-24 | [PFC_WD] Avoid applying ZeroBuffer Profiles to ingress PG when a PFC storm is detected (sonic-net#2304) (HEAD -> 202205) [Vivek R] * ef75554 2022-06-25 | [swssconfig] Optimize performance of swssconfig (sonic-net#2336) [Junchao-Mellanox] * d9e9ba8 2022-06-24 | [fdborch] fix heap-use-after-free in clearFdbEntry() (sonic-net#2353) [Yakiv Huryk] * 585a69b 2022-06-24 | Create ACL table fails due to incorrect check for supported ACL actions sonic-net#11235 (sonic-net#2351) [Ravindranath C K] * 0d19560 2022-06-24 | [macsec] Refactor the logic of macsec name map (sonic-net#2348) [Junhua Zhai] * 111dfc2 2022-06-23 | [macsec] Update macsec flex counter (sonic-net#2338) (HEAD -> 202205, github/202205) [Junhua Zhai] swss-common: * 0213d55 2022-06-23 | [portcounter] Check if counter ID exists before arithmetic operation (sonic-net#632) (HEAD -> 202205, github/202205) [Junhua Zhai] * c21c47e 2022-06-14 | [counter] Add counter table (sonic-net#622) [Junhua Zhai] utilities: * 430cd65 2022-06-23 | [202205] [generate dump] Move the Core/Log collection to the End of process Execution and removed default timeout (sonic-net#2230) (github/202205) [Vivek R] linkmgrd: * 59334be 2022-06-24 | Remove exception throwing when initializing missing loopback interface (sonic-net#90) (HEAD -> 202205) [Jing Zhang] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
vivekrnv
pushed a commit
to vivekrnv/sonic-buildimage
that referenced
this pull request
Aug 26, 2022
- What I did using a copy of FDBEntry fields (stored in FDBUpdate) instead of a reference since the reference gets invalidated in the storeFdbEntryState() simplified clearFdbEntry() interface - Why I did it To fix the memory usage issue The issue is that the SWSS_LOG_INFO() uses the mac&, port_alias&, and bv_id& which are invalidated in the storeFdbEntryState(). - How I verified it Run the tests that were used to find the issues and checked the ASAN report Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com>
dgsudharsan
added a commit
to dgsudharsan/sonic-buildimage
that referenced
this pull request
Sep 13, 2022
Update sonic-utilities submodule pointer to include the following: * [202012][VxLAN]VxLAN Tunnel Counters and Rates implementation ([sonic-net#2353](sonic-net/sonic-utilities#2353)) Signed-off-by: dgsudharsan <sudharsand@nvidia.com>
prsunny
pushed a commit
that referenced
this pull request
Sep 14, 2022
Update sonic-utilities submodule pointer to include the following: * [202012][VxLAN]VxLAN Tunnel Counters and Rates implementation ([#2353](sonic-net/sonic-utilities#2353))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
When migrating configuration, always copy config files from old_config
to /etc/sonic. But if warm reboot is detected, then skip configuration
operations.
- How to verify it
warm reboot into another newly installed image with the fix.
Before the fix, when warm reboot into a new image, warm boot flag would be lost and the boot up path would execute cold boot; with the fix, the boot up path executes warm boot.