Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DCS-7060CX-32S support in boot0 #243

Merged
merged 1 commit into from
Feb 4, 2017
Merged

Add DCS-7060CX-32S support in boot0 #243

merged 1 commit into from
Feb 4, 2017

Conversation

Staphylo
Copy link
Collaborator

@Staphylo Staphylo commented Feb 2, 2017

Set the proper cmdline arguments to boot on a DCS-7060CX-32S in boot0.

@lguohan and @qiluo-msft in all the sonic codebase it seems like the hw_sku names for Arista platforms differs from the ones we actually give.
You use either arista_7050_qx32s or Arista-7050-QX32S in place of DCS-7050QX-32S. I agree that replacing DCS by Arista is better in this case but the dash/underscore being moved will yield some strange naming at some point.
Consider the SKU DCS-7050QX2-32S. With this one you'll end up with Arista-7050-QX232S since consistency matters in the naming.
I personally don't mind much since the transformation from our SKU naming to this one is easily done programatically but I wanted to bring that up before we add more platform and while we can still change it.
So I was wondering if I should go ahead and do the changes in sonic-buildimage (syncd, orchagent, boot0) and sonic-mgmt everywhere for the Arista-7050QX-32.
Otherwise, should I just do this only for the new platforms or should I just drop the idea and continue with the way it is currently done?

@lguohan
Copy link
Collaborator

lguohan commented Feb 3, 2017

there are two types of hardware skus in sonic. one is the real hardware sku, and another one is datacenter hw sku. The real hardware sku is used for load platform drivers, it should come from vendor. the dc hardware sku is mainly used for determine the wiring pattern since in datacenter scenario the wire pattern (port breakout mode) for a box is predefined. The one embedded in the minigraph is the dc hardware sku.

for you, I think you really care about the real hardware sku, we can follow your suggestion, for example Arista-7050QX2-32S ans use this to load specific platform driver.

As for the dc hardware sku, it is usually real hardware sku + breakout pattern string. It is mainly used in syncd process to supply the port configuration. Sometimes, the breakout pattern string is null to denote no breakout for all port.

In short, I think we probably should do followings:

  1. seperate hwsku and dc_hwsku
  2. adopt vendor name preferred name for the hwsku
  3. standardize dc_hwsku or create a mapping between dc_hwsku to (hwsku, breakout mode).

@lguohan lguohan merged commit 92b32fd into sonic-net:master Feb 4, 2017
lguohan added a commit to lguohan/sonic-buildimage that referenced this pull request Nov 12, 2018
sairedis

* 248a095 2018-11-07 | Add best candidate search for acl table (sonic-net#371) [Kamil Cudnik]
* d1e26c3 2018-11-07 | Ignore order when compare QOS MAP list entries (sonic-net#372) [Kamil Cudnik]
* e8df347 2018-11-05 | Add best candidate search for router interface using tunnel term tabl… (sonic-net#370) [Kamil Cudnik]
* 8ae173b 2018-11-01 | Refactor saidump graph generator (sonic-net#367) [Kamil Cudnik]

common

* 2a37c5c 2018-11-07 | Add system warm-reboot check in WarmRestart class (sonic-net#246) (HEAD, origin/master, origin/HEAD) [zhenggen-xu]
* fb082b5 2018-11-06 | Fix ProducerStateTable::clear() to clear StateHash properly (sonic-net#244) [Taoyu Li]
* 0ee636b 2018-11-05 | Remove local googletest submodule and link with system gtest (sonic-net#245) [Qi Luo]
* b56ffba 2018-10-31 | Add NEIGH_RESTORE_TABLE in stateDB (sonic-net#243) [zhenggen-xu]
* b58c69d 2018-10-28 | swss-common: add op 'create' case to avoid flush immediately (sonic-net#219) [Dong Zhang]

swss
* afdcf34 2018-11-12 | Support neighsyncd system warmreboot. (sonic-net#661) (HEAD, origin/master, origin/HEAD) [zhenggen-xu]
* f380685 2018-11-09 | Routing-stack warm-reboot feature. (sonic-net#602) [Rodny Molina]
* 9fbcb60 2018-11-09 | Add warm-reboot mode for teammgrd (sonic-net#678) [pavel-shirshov]
* 8c60787 2018-11-09 | Don't add loopback ip2me route again if already configured (sonic-net#656) [Jipan Yang]
* 6eb1613 2018-11-08 | [test]: Add interface IPv6 add/remove test case (sonic-net#677) [Shuotian Cheng]
* 5de5054 2018-11-07 | [vrfmgrd]: Support VNET setting (sonic-net#657) [Marian Pritsak]
* f666011 2018-11-06 | [teammgrd]: Add retry logic when enslaving member port into team (sonic-net#669) [Shuotian Cheng]
* 36e304d 2018-11-05 | [vstest]: print output when runcmd returns error (sonic-net#672) [lguohan]
* aede5d4 2018-11-05 | [test]: Fix clean up wrong interface IP (sonic-net#673) [Shuotian Cheng]
* aeceaca 2018-11-02 | [portmgrd]: portmgrd shall be responsible for all ports update (sonic-net#668) [Shuotian Cheng]
* 5796e54 2018-11-02 | Orchagent warm restart data restore requires three iterations (sonic-net#670) [Jipan Yang]
* 15a2299 2018-11-01 | [vlanmgrd]: Do not bring up VLAN members by default (sonic-net#667) [Shuotian Cheng]
* 44a4460 2018-11-01 | [test]: Clean up LAGs after finishing the test (sonic-net#666) [Shuotian Cheng]

Signed-off-by: Guohan Lu <gulv@microsoft.com>
lguohan added a commit that referenced this pull request Nov 12, 2018
sairedis

* 248a095 2018-11-07 | Add best candidate search for acl table (#371) [Kamil Cudnik]
* d1e26c3 2018-11-07 | Ignore order when compare QOS MAP list entries (#372) [Kamil Cudnik]
* e8df347 2018-11-05 | Add best candidate search for router interface using tunnel term tabl… (#370) [Kamil Cudnik]
* 8ae173b 2018-11-01 | Refactor saidump graph generator (#367) [Kamil Cudnik]

common

* 2a37c5c 2018-11-07 | Add system warm-reboot check in WarmRestart class (#246) (HEAD, origin/master, origin/HEAD) [zhenggen-xu]
* fb082b5 2018-11-06 | Fix ProducerStateTable::clear() to clear StateHash properly (#244) [Taoyu Li]
* 0ee636b 2018-11-05 | Remove local googletest submodule and link with system gtest (#245) [Qi Luo]
* b56ffba 2018-10-31 | Add NEIGH_RESTORE_TABLE in stateDB (#243) [zhenggen-xu]
* b58c69d 2018-10-28 | swss-common: add op 'create' case to avoid flush immediately (#219) [Dong Zhang]

swss
* afdcf34 2018-11-12 | Support neighsyncd system warmreboot. (#661) (HEAD, origin/master, origin/HEAD) [zhenggen-xu]
* f380685 2018-11-09 | Routing-stack warm-reboot feature. (#602) [Rodny Molina]
* 9fbcb60 2018-11-09 | Add warm-reboot mode for teammgrd (#678) [pavel-shirshov]
* 8c60787 2018-11-09 | Don't add loopback ip2me route again if already configured (#656) [Jipan Yang]
* 6eb1613 2018-11-08 | [test]: Add interface IPv6 add/remove test case (#677) [Shuotian Cheng]
* 5de5054 2018-11-07 | [vrfmgrd]: Support VNET setting (#657) [Marian Pritsak]
* f666011 2018-11-06 | [teammgrd]: Add retry logic when enslaving member port into team (#669) [Shuotian Cheng]
* 36e304d 2018-11-05 | [vstest]: print output when runcmd returns error (#672) [lguohan]
* aede5d4 2018-11-05 | [test]: Fix clean up wrong interface IP (#673) [Shuotian Cheng]
* aeceaca 2018-11-02 | [portmgrd]: portmgrd shall be responsible for all ports update (#668) [Shuotian Cheng]
* 5796e54 2018-11-02 | Orchagent warm restart data restore requires three iterations (#670) [Jipan Yang]
* 15a2299 2018-11-01 | [vlanmgrd]: Do not bring up VLAN members by default (#667) [Shuotian Cheng]
* 44a4460 2018-11-01 | [test]: Clean up LAGs after finishing the test (#666) [Shuotian Cheng]

Signed-off-by: Guohan Lu <gulv@microsoft.com>
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020
Mirror action now could be applied to any type of ACL rules.
dmytroxshevchuk pushed a commit to dmytroxshevchuk/sonic-buildimage that referenced this pull request Aug 31, 2020
* Fix configure parameter name

Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>

* Move tests to syncd directory, add consumer in tests

Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>

* Test for bulk create nhgm

Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>

* Refactor namespace prefix

Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>

* Fix reference

Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>

* Fix function paramter reference

Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>
lguohan pushed a commit that referenced this pull request Dec 3, 2021
c2aac75 [SFP-Refactor] Fix LP mode API issue (#247)
dba17c8 Firmware upgrade CLI support for QSFP-DD transceivers (#244)
cd69212 [SFP-Refactor] Implement CMIS Low Power mode (#237)
9cea07f Fix RegGroupField decode (#245)
6ae1909 Add CMIS QSFP support (#246)
c1f317d Gracefully handle CMIS APIs for passive modules (#238)
ec7335d fix for firmware functions  (#243)
cf2ebe9 Fix RegBitField decode/encode (#242)
ef4f2c6 Fix SFP_CABLE_TECH_FIELD (#240)
e118644 remove time counting message in functions because function running time could be difficult to predict in unit tests (#241)

Signed-off-by: Prince George <prgeor@microsoft.com>
abdosi pushed a commit that referenced this pull request Dec 8, 2021
c2aac75 [SFP-Refactor] Fix LP mode API issue (#247)
dba17c8 Firmware upgrade CLI support for QSFP-DD transceivers (#244)
cd69212 [SFP-Refactor] Implement CMIS Low Power mode (#237)
9cea07f Fix RegGroupField decode (#245)
6ae1909 Add CMIS QSFP support (#246)
c1f317d Gracefully handle CMIS APIs for passive modules (#238)
ec7335d fix for firmware functions  (#243)
cf2ebe9 Fix RegBitField decode/encode (#242)
ef4f2c6 Fix SFP_CABLE_TECH_FIELD (#240)
e118644 remove time counting message in functions because function running time could be difficult to predict in unit tests (#241)

Signed-off-by: Prince George <prgeor@microsoft.com>
@judyjoseph judyjoseph mentioned this pull request Apr 8, 2022
6 tasks
sg893052 pushed a commit to sg893052/sonic-buildimage that referenced this pull request Apr 25, 2022
stepanblyschak added a commit to stepanblyschak/sonic-buildimage that referenced this pull request Jul 6, 2022
```
bc9fe5b [202106][patch] mlxsw: i2c: Prevent transaction execution for special chip states (sonic-net#283)
5797acf [202106][max6620] Backport max6620 hwmon driver to linux version 4.19 (sonic-net#243)
```

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
mihirpat1 pushed a commit to mihirpat1/sonic-buildimage that referenced this pull request Feb 21, 2023
snider-nokia pushed a commit to snider-nokia/sonic-buildimage that referenced this pull request Apr 6, 2023
* fix for firmware functions 1. report updated address, count and remaining bytes info in module_fw_download() 2. remove additional 200 ms wait time in block_write_lpl() and block_write_epl() 3. increase max wait time to 1 min in cdb1_chkstatus() if status is not 1. If status is password error (70) it will break the wait loop. 4. add protection to failed_status_dict

* change cdb1_chkstatus(): only wait if status is busy

* change cdb1_chkstatus(): only wait if status is busy
vivekrnv pushed a commit to vivekrnv/sonic-buildimage that referenced this pull request Mar 18, 2024
Why I did it
Need new update for sonic-gnmi.

How I did it
Move submodule for sonic-gnmi.

How to verify it
Build image and run end2end test
mssonicbld added a commit that referenced this pull request Jun 27, 2024
…lly (#19325)

#### Why I did it
src/sonic-gnmi
```
* a610784 - (HEAD -> master, origin/master, origin/HEAD) Improve timeout for GNMI dbus service (#265) (3 days ago) [ganglv]
* b1c90c9 - Add unit test for vlan interface (#264) (6 days ago) [ganglv]
* fbf0234 - Add unit test for syslog config (#263) (6 days ago) [ganglv]
* 047fc29 - Add unit test for portchannel interface (#262) (6 days ago) [ganglv]
* 52dd8e7 - Add unit test for pg headroom (#261) (6 days ago) [ganglv]
* 8a10d9f - Add unit test for pfcwd status (#260) (6 days ago) [ganglv]
* 65a43bc - Add unit test for pfcwd interval (#259) (6 days ago) [ganglv]
* 0bbb9ef - Add unit test for ntp (#258) (7 days ago) [ganglv]
* e5c43a4 - Add unit test for monitor config (#257) (7 days ago) [ganglv]
* 8a8881e - Add unit test for mmu dynamic threshold (#256) (7 days ago) [ganglv]
* 76857df - Add unit test for lo interface (#255) (7 days ago) [ganglv]
* c35c69d - Add unit test for k8s config (#254) (8 days ago) [ganglv]
* dd0bdcf - Add unit test for IPV6 (#253) (8 days ago) [ganglv]
* 9a1133f - Add unit test for incremental qos (#252) (8 days ago) [ganglv]
* 9bf7969 - Add unit test for eth interface (#251) (8 days ago) [ganglv]
* 2e1eb05 - Add unit test for ECN config (#250) (8 days ago) [ganglv]
* 56f17eb - Add unit test for dynamic ACL (#249) (8 days ago) [ganglv]
* 388eba8 - Add unit test for DHCP relay (#245) (10 days ago) [ganglv]
* fd2fdf6 - Add unit test for CACL (#243) (11 days ago) [ganglv]
```
#### How I did it
#### How to verify it
#### Description for the changelog
arun1355492 pushed a commit to arun1355492/sonic-buildimage that referenced this pull request Jul 26, 2024
…lly (sonic-net#19325)

#### Why I did it
src/sonic-gnmi
```
* a610784 - (HEAD -> master, origin/master, origin/HEAD) Improve timeout for GNMI dbus service (sonic-net#265) (3 days ago) [ganglv]
* b1c90c9 - Add unit test for vlan interface (sonic-net#264) (6 days ago) [ganglv]
* fbf0234 - Add unit test for syslog config (sonic-net#263) (6 days ago) [ganglv]
* 047fc29 - Add unit test for portchannel interface (sonic-net#262) (6 days ago) [ganglv]
* 52dd8e7 - Add unit test for pg headroom (sonic-net#261) (6 days ago) [ganglv]
* 8a10d9f - Add unit test for pfcwd status (sonic-net#260) (6 days ago) [ganglv]
* 65a43bc - Add unit test for pfcwd interval (sonic-net#259) (6 days ago) [ganglv]
* 0bbb9ef - Add unit test for ntp (sonic-net#258) (7 days ago) [ganglv]
* e5c43a4 - Add unit test for monitor config (sonic-net#257) (7 days ago) [ganglv]
* 8a8881e - Add unit test for mmu dynamic threshold (sonic-net#256) (7 days ago) [ganglv]
* 76857df - Add unit test for lo interface (sonic-net#255) (7 days ago) [ganglv]
* c35c69d - Add unit test for k8s config (sonic-net#254) (8 days ago) [ganglv]
* dd0bdcf - Add unit test for IPV6 (sonic-net#253) (8 days ago) [ganglv]
* 9a1133f - Add unit test for incremental qos (sonic-net#252) (8 days ago) [ganglv]
* 9bf7969 - Add unit test for eth interface (sonic-net#251) (8 days ago) [ganglv]
* 2e1eb05 - Add unit test for ECN config (sonic-net#250) (8 days ago) [ganglv]
* 56f17eb - Add unit test for dynamic ACL (sonic-net#249) (8 days ago) [ganglv]
* 388eba8 - Add unit test for DHCP relay (sonic-net#245) (10 days ago) [ganglv]
* fd2fdf6 - Add unit test for CACL (sonic-net#243) (11 days ago) [ganglv]
```
#### How I did it
#### How to verify it
#### Description for the changelog
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Aug 1, 2024
…lly (sonic-net#19325)

#### Why I did it
src/sonic-gnmi
```
* a610784 - (HEAD -> master, origin/master, origin/HEAD) Improve timeout for GNMI dbus service (sonic-net#265) (3 days ago) [ganglv]
* b1c90c9 - Add unit test for vlan interface (sonic-net#264) (6 days ago) [ganglv]
* fbf0234 - Add unit test for syslog config (sonic-net#263) (6 days ago) [ganglv]
* 047fc29 - Add unit test for portchannel interface (sonic-net#262) (6 days ago) [ganglv]
* 52dd8e7 - Add unit test for pg headroom (sonic-net#261) (6 days ago) [ganglv]
* 8a10d9f - Add unit test for pfcwd status (sonic-net#260) (6 days ago) [ganglv]
* 65a43bc - Add unit test for pfcwd interval (sonic-net#259) (6 days ago) [ganglv]
* 0bbb9ef - Add unit test for ntp (sonic-net#258) (7 days ago) [ganglv]
* e5c43a4 - Add unit test for monitor config (sonic-net#257) (7 days ago) [ganglv]
* 8a8881e - Add unit test for mmu dynamic threshold (sonic-net#256) (7 days ago) [ganglv]
* 76857df - Add unit test for lo interface (sonic-net#255) (7 days ago) [ganglv]
* c35c69d - Add unit test for k8s config (sonic-net#254) (8 days ago) [ganglv]
* dd0bdcf - Add unit test for IPV6 (sonic-net#253) (8 days ago) [ganglv]
* 9a1133f - Add unit test for incremental qos (sonic-net#252) (8 days ago) [ganglv]
* 9bf7969 - Add unit test for eth interface (sonic-net#251) (8 days ago) [ganglv]
* 2e1eb05 - Add unit test for ECN config (sonic-net#250) (8 days ago) [ganglv]
* 56f17eb - Add unit test for dynamic ACL (sonic-net#249) (8 days ago) [ganglv]
* 388eba8 - Add unit test for DHCP relay (sonic-net#245) (10 days ago) [ganglv]
* fd2fdf6 - Add unit test for CACL (sonic-net#243) (11 days ago) [ganglv]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants